From: Grant Edwards <grante@visi.com>
To: Doug Evans <dje@transmeta.com>
Cc: "Newman,
Mark (N-Superior Technical Resource Inc)" <mark.newman@lmco.com>,
gdb@sources.redhat.com
Subject: Re: filtering of commands during async operation
Date: Wed, 05 Nov 2003 22:00:00 -0000 [thread overview]
Message-ID: <20031105220245.GA4424@grante.dsl.visi.com> (raw)
In-Reply-To: <16297.28959.958906.509597@casey.transmeta.com>
> Good example of why it's useful to avoid using ! with strcmp.
>
> > The code should be:
> >
> > if (event_loop_p && target_can_async_p () && target_executing) {
> > if (!(strcmp (c->name, "help") == 0)
> > && !(strcmp (c->name, "pwd") == 0)
> > && !(strcmp (c->name, "show") == 0)
> > && !(strcmp (c->name, "stop") == 0)) {
> > error ("Cannot execute this command while the target is running.");
> > }
> > }
> >
> > Unless someone objects I am going to put in a bug report and a patch.
>
> Why not just strcmp () != 0
Why not just strcmp() ?
if (strcmp()
&& strcmp()
&& strcmp())
--
Grant Edwards
grante@visi.com
next prev parent reply other threads:[~2003-11-05 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-05 21:11 Newman, Mark (N-Superior Technical Resource Inc)
2003-11-05 21:52 ` Doug Evans
2003-11-05 22:00 ` Grant Edwards [this message]
2003-11-05 22:10 ` Paul Koning
2003-11-05 23:11 ` Elena Zannoni
2003-11-06 14:32 Newman, Mark (N-Superior Technical Resource Inc)
2003-11-06 16:57 ` Elena Zannoni
[not found] <1068129153.32379.ezmlm@sources.redhat.com>
2003-11-06 17:38 ` Jim Ingham
2003-11-06 19:41 ` Elena Zannoni
2003-11-06 21:16 ` Jim Ingham
2003-11-06 22:10 ` Andrew Cagney
2003-11-06 22:29 ` Elena Zannoni
2003-11-06 22:26 ` Elena Zannoni
2003-11-07 16:00 Newman, Mark (N-Superior Technical Resource Inc)
2003-11-07 16:14 ` Daniel Jacobowitz
2003-11-07 17:03 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031105220245.GA4424@grante.dsl.visi.com \
--to=grante@visi.com \
--cc=dje@transmeta.com \
--cc=gdb@sources.redhat.com \
--cc=mark.newman@lmco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox