From: Joel Brobecker <brobecker@gnat.com>
To: David Carlton <carlton@kealia.com>
Cc: Andrew Cagney <ac131313@redhat.com>,
binutils@sources.redhat.com, gdb@sources.redhat.com
Subject: Re: A gdb+bfd string pool?
Date: Tue, 04 Nov 2003 08:16:00 -0000 [thread overview]
Message-ID: <20031104081622.GB883@gnat.com> (raw)
In-Reply-To: <yf2sml5jreg.fsf@hawaii.kealia.com>
> Personally, I'd be against this unless we have reason to believe that
> it's an important optimization. I don't like global data in general,
> even if it's only global to one component of a program, and having
> that data shared by both GDB and BFD makes me even more nervous.
> (Singleton is not my favorite design pattern.) So it sets of warning
> bells for general design reasons; our lack of const-correctness when
> dealing with names makes me even more nervous.
I have the exact same feeling.
May I recommend that, should we decide to use one, we isolate it from
GDB's code via a layer. So each module would use it's layer as if it was
not shared. It will make the move back easier, in case it's ever needed.
--
Joel
next prev parent reply other threads:[~2003-11-04 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-31 15:15 Andrew Cagney
2003-10-31 15:19 ` Daniel Jacobowitz
2003-10-31 15:45 ` Andrew Cagney
2003-10-31 15:51 ` Daniel Jacobowitz
2003-10-31 17:29 ` Andrew Cagney
2003-10-31 17:36 ` Jakub Jelinek
2003-10-31 17:45 ` Andrew Cagney
2003-11-03 17:25 ` David Carlton
2003-11-04 8:16 ` Joel Brobecker [this message]
2003-11-04 16:31 ` Andrew Cagney
2003-11-04 23:51 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031104081622.GB883@gnat.com \
--to=brobecker@gnat.com \
--cc=ac131313@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=carlton@kealia.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox