From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 339 invoked by alias); 20 Mar 2003 15:39:37 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 329 invoked from network); 20 Mar 2003 15:39:35 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 20 Mar 2003 15:39:35 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h2KFdZQ08111 for ; Thu, 20 Mar 2003 10:39:35 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2KFdYQ29669 for ; Thu, 20 Mar 2003 10:39:34 -0500 Received: from cygbert.vinschen.de (vpn50-20.rdu.redhat.com [172.16.50.20]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h2KFdX528845 for ; Thu, 20 Mar 2003 07:39:33 -0800 Received: (from corinna@localhost) by cygbert.vinschen.de (8.11.6/8.9.3/Linux sendmail 8.9.3) id h2KFdUM02916 for gdb@sources.redhat.com; Thu, 20 Mar 2003 16:39:30 +0100 Date: Thu, 20 Mar 2003 15:39:00 -0000 From: Corinna Vinschen To: gdb@sources.redhat.com Subject: Re: Where to set correct value for tdep->struct_return for Cygwin? Message-ID: <20030320153930.GZ21269@cygbert.vinschen.de> Mail-Followup-To: gdb@sources.redhat.com References: <20030320152019.GA2699@cygbert.vinschen.de> <3E79DDFB.4030003@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E79DDFB.4030003@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-03/txt/msg00302.txt.bz2 On Thu, Mar 20, 2003 at 10:27:55AM -0500, Andrew Cagney wrote: > >Hi, > > > >I just found the following problem: > > > >In i386-tdep.c::i386_gdbarch_init(), tdep->struct_return is set to > >pcc_struct_return by default. Several i386 targets set this value > >in their appropriate _init function to reg_struct_return (e. g. the > >bsd and interix targets). > > > >Cygwin is using reg_struct_return as well but unfortunately in contrast > >to Interix it has no own tdep.c file and so there's no appropriate _init > >function as e. g. i386_interix_init_abi() available to set that value. > >This results in having tdep->struct_return still set to pcc_struct_return > >and about 25 fails in the testsuite. > > > >So the question is, where to set that value? Shall we add a new > >cygwin-tdep.c > >file, just to set this one value? Or is there some already existing > >obvious > >place to do this? win32-nat.c seems to be not a good chice, btw. > > If both interix and cygwin are sharing a common ABI, then shouldn't that > common ABI code live in i386-win32-tdep.c? I didn't say Interix and Cygwin share a common ABI. It's just this one the same. Interix adds some additional stuff which isn't the same for Cygwin. Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc. mailto:vinschen@redhat.com