[PATCH] Re: regcache (Re: GDB respin)

[Mark Kettenis <kettenis@chello.nl>]

   Date: Thu, 06 Feb 2003 13:14:16 -0500
   From: Andrew Cagney <ac131313@redhat.com>

   > diff -u -p -r1.33 -r1.34
   > --- gdb/x86-64-tdep.c   26 Oct 2002 10:37:45 -0000      1.33
   > +++ gdb/x86-64-tdep.c   26 Oct 2002 16:56:34 -0000      1.34
   > @@ -925,11 +925,35 @@ x86_64_init_abi (struct gdbarch_info inf
   > +  set_gdbarch_long_double_bit (gdbarch, 128);
   > +  set_gdbarch_ps_regnum (gdbarch, 17); /* %eflags */
   > +  set_gdbarch_stab_reg_to_regnum (gdbarch, x86_64_dwarf2_reg_to_regnum);
   > +  set_gdbarch_dwarf_reg_to_regnum (gdbarch, x86_64_dwarf2_reg_to_regnum);
   > +  set_gdbarch_extract_return_value (gdbarch, NULL);
   > +  set_gdbarch_store_return_value (gdbarch, NULL);
   > +  set_gdbarch_extract_struct_value_address (gdbarch, NULL);
   > 
   > If I comment out last three lines (those return_value related), the testsuite performs much better. But all the other lines seem have some influence on the results.

   Hmm, at least extract_return_value shouldn't be set to NULL.  It should 
   be doing:
	   extract-return-value()
	   -> legacy-extract-return-value()
	   -> deprecated-extract-return-value()
	   -> x86-64-extract-return-value
   So I'd at least remove the setting of that one.  Since it is trying to 
   restore the default, try setting it to legacy_...().  Same goes for 
   store_return_value.  I think extract_struct_value_address is puzzling 
   but ok.

Looks like I screwed up by assuming that setting things to NULL would
make us invoke the default.  Although I'd encourage Ludvig to make
these functions regcache aware, I checked in the attached patch.  I
think it would be a good idea to have things working correctly before
starting the conversion.

Mark

Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* x86-64-tdep.c (x86_64_init_abi): Set extract_return_value to
	legacy_extract_return_value and store_return_value to
	legacy_return_value.

Index: x86-64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v
retrieving revision 1.46
diff -u -p -r1.46 x86-64-tdep.c
--- x86-64-tdep.c 5 Jan 2003 14:07:03 -0000 1.46
+++ x86-64-tdep.c 6 Feb 2003 23:20:18 -0000
@@ -980,7 +980,7 @@ x86_64_init_abi (struct gdbarch_info inf
   set_gdbarch_read_fp (gdbarch, cfi_read_fp);
 
   /* FIXME: kettenis/20021026: Should be undeprecated.  */
-  set_gdbarch_extract_return_value (gdbarch, NULL);
+  set_gdbarch_extract_return_value (gdbarch, legacy_extract_return_value);
   set_gdbarch_deprecated_extract_return_value (gdbarch,
 					       x86_64_extract_return_value);
   set_gdbarch_push_arguments (gdbarch, x86_64_push_arguments);
@@ -988,7 +988,7 @@ x86_64_init_abi (struct gdbarch_info inf
   set_gdbarch_pop_frame (gdbarch, x86_64_pop_frame);
   set_gdbarch_store_struct_return (gdbarch, x86_64_store_struct_return);
   /* FIXME: kettenis/20021026: Should be undeprecated.  */
-  set_gdbarch_store_return_value (gdbarch, NULL);
+  set_gdbarch_store_return_value (gdbarch, legacy_store_return_value);
   set_gdbarch_deprecated_store_return_value (gdbarch,
 					     x86_64_store_return_value);
   /* Override, since this is handled by x86_64_extract_return_value.  */