From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-12107-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 7502 invoked by alias); 26 Jan 2003 19:38:44 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 7495 invoked from network); 26 Jan 2003 19:38:43 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by 172.16.49.205 with SMTP; 26 Jan 2003 19:38:43 -0000
Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136])
	by Cantor.suse.de (Postfix) with ESMTP
	id 5105814C13; Sun, 26 Jan 2003 20:38:43 +0100 (MET)
Date: Sun, 26 Jan 2003 19:38:00 -0000
From: Olaf Hering <olh@suse.de>
To: gdb@sources.redhat.com, Will Schmidt <willschm@us.ibm.com>
Subject: Re: remove enum from ppc-linux-tdep.c
Message-ID: <20030126193843.GA23713@suse.de>
References: <20030126192055.GA22537@suse.de> <20030126193104.GA2143@nevyn.them.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030126193104.GA2143@nevyn.them.org>
X-DOS: I got your 640K Real Mode Right Here Buddy!
X-Homeland-Security: You are not supposed to read this line! You are a terrorist!
User-Agent: Mutt und vi sind doch schneller als Notes
X-SW-Source: 2003-01/txt/msg00422.txt.bz2

 On Sun, Jan 26, Daniel Jacobowitz wrote:

> On Sun, Jan 26, 2003 at 08:20:55PM +0100, Olaf Hering wrote:
> > Hi,
> > 
> > this patch uses the defines from asm/elf.h instead of the hardcoded
> > values. Would that have any bad side effects? asm-ppc64 includes elf.h
> > via sigcontext.h and that will result in a syntax error.
> 
> 
> > +#include "<asm/elf.h>"
> 
> First of all, that's a syntax error :)

sigh...

> Secondly, tdep stands for target dependant.  This needs to work from
> any host platform.  The right thing to do is probably to rename the
> enum: PPC_LINUX_ELF_NGREG, or something like that.
> 
> [Or fix your headers.  That's pretty bad namespace polution.  It
> shouldn't do that.]

Ok, I will leave that to Will.
Thanks for the pointers.

Gruss Olaf

-- 
A: No.
Q: Should I include quotations after my reply?