From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-12105-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 3890 invoked by alias); 26 Jan 2003 19:21:00 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 3880 invoked from network); 26 Jan 2003 19:21:00 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by 172.16.49.205 with SMTP; 26 Jan 2003 19:21:00 -0000
Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136])
	by Cantor.suse.de (Postfix) with ESMTP
	id 762E014C30; Sun, 26 Jan 2003 20:20:59 +0100 (MET)
Date: Sun, 26 Jan 2003 19:21:00 -0000
From: Olaf Hering <olh@suse.de>
To: gdb@sources.redhat.com, Will Schmidt <willschm@us.ibm.com>
Subject: remove enum from ppc-linux-tdep.c
Message-ID: <20030126192055.GA22537@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-DOS: I got your 640K Real Mode Right Here Buddy!
X-Homeland-Security: You are not supposed to read this line! You are a terrorist!
User-Agent: Mutt und vi sind doch schneller als Notes
X-SW-Source: 2003-01/txt/msg00420.txt.bz2

Hi,

this patch uses the defines from asm/elf.h instead of the hardcoded
values. Would that have any bad side effects? asm-ppc64 includes elf.h
via sigcontext.h and that will result in a syntax error.

Index: ppc-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v
retrieving revision 1.22
diff -u -p -r1.22 ppc-linux-tdep.c
--- ppc-linux-tdep.c    4 Jan 2003 23:38:45 -0000       1.22
+++ ppc-linux-tdep.c    26 Jan 2003 19:15:27 -0000
@@ -36,6 +36,8 @@
 #include "solib-svr4.h"
 #include "ppc-tdep.h"

+#include "<asm/elf.h>"
+
 /* The following two instructions are used in the signal trampoline
    code on GNU/Linux PPC.  */
 #define INSTR_LI_R0_0x7777     0x38007777
@@ -607,12 +609,6 @@ ppc_linux_svr4_fetch_link_map_offsets (v

   return lmp;
 }
-
-enum {
-  ELF_NGREG = 48,
-  ELF_NFPREG = 33,
-  ELF_NVRREG = 33
-};

 enum {
   ELF_GREGSET_SIZE = (ELF_NGREG * 4),


-- 
A: No.
Q: Should I include quotations after my reply?