From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 701 invoked by alias); 9 Jan 2003 04:24:23 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 683 invoked from network); 9 Jan 2003 04:24:22 -0000 Received: from unknown (HELO duracef.shout.net) (204.253.184.12) by 209.249.29.67 with SMTP; 9 Jan 2003 04:24:22 -0000 Received: (from mec@localhost) by duracef.shout.net (8.11.6/8.11.6) id h094O8224303; Wed, 8 Jan 2003 22:24:08 -0600 Date: Thu, 09 Jan 2003 04:24:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200301090424.h094O8224303@duracef.shout.net> To: carlton@math.stanford.edu Subject: Re: [rfc] plans for linespec.c Cc: ezannoni@redhat.com, fnasser@redhat.com, gdb@sources.redhat.com, jimb@redhat.com X-SW-Source: 2003-01/txt/msg00115.txt.bz2 Hi David, > ... I'm not sure that your level of concern is warranted. My machine > is old, so it would turn a 10-minute testing process into a 20-minute > testing process; I'm happy to do that if you think it's important, > but I'm not sure that it is in this particular instance. It's kinda subjective. I tend to be conservative about these things, and I tend not to think of testing as getting in the way of my work flow (I like to proofread while the tests are running). So it's not "you should I do this or I predict calamity" issue. If you choose not to, I won't kick. If lots of new stabs+ regressions show up then I will want it more. I know decode_line_1 does not touch symbol table implementation much but the symbols that come in from the different symbol table readers are quite, well, different. In fact I'd like to add coff or xcoff to my own testing. > (I am, however, worried about problems that the test suite might not > catch at all: it would be nice if somebody were to make sure that the > testsuite systematically tested everything that decode_line_1 does. > But that's another issue entirely.) Grin. You are the expert on coverage cases for decode_line_1 now! Unfortunately it's very difficult psychologically to work on a piece of code and then write test cases designed to break it. Michael C