From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16585 invoked by alias); 8 Jan 2003 18:16:35 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 16412 invoked from network); 8 Jan 2003 18:16:28 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 209.249.29.67 with SMTP; 8 Jan 2003 18:16:28 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18WMcQ-00008h-00; Wed, 08 Jan 2003 14:16:06 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18WKk0-0007E1-00; Wed, 08 Jan 2003 13:15:48 -0500 Date: Wed, 08 Jan 2003 18:16:00 -0000 From: Daniel Jacobowitz To: Sunil Alankar , gdb@sources.redhat.com Subject: Re: GDB 5.2/5.3 breakpoint bug Message-ID: <20030108181548.GA27461@nevyn.them.org> Mail-Followup-To: Sunil Alankar , gdb@sources.redhat.com References: <20030108173931.GB22279@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030108173931.GB22279@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00084.txt.bz2 On Wed, Jan 08, 2003 at 12:39:31PM -0500, Daniel Jacobowitz wrote: > On Tue, Jan 07, 2003 at 03:49:31PM -0800, Sunil Alankar wrote: > > Hi, > > > > While debugging this in function, find_pc_sect_line (CORE_ADDR pc, struct > > sec *section, int notcurrent) > > I found there were two line items in a line table with the same value of PC. > > First one gets picked as the best match. But this had item->line == 0. The > > next line item with the same value for item->pc, but a valid item->line ( > > > 0) does not get picked as the best match. > > I put in the following check to correct this. My question is, > > Is it valid to have have more than one line item with same value faor PC and > > possibly 0 for line in one of them? What causes this? > > Would this be an appropriate fix? Or is the problem more deep rooted in > > creating the symbol table? > > When this happens, are the two lines in different files? I just can't get this to happen. If two items in a row have the same PC, we should never be picking the first of the two. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer