Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Klee Dienes <klee@apple.com>,
	binutils@sources.redhat.com, gdb@sources.redhat.com
Subject: Re: [RFA] Replace strdup with xstrdup in tic30-dis.c
Date: Tue, 26 Nov 2002 14:37:00 -0000	[thread overview]
Message-ID: <20021126223746.GQ949@bubble.sa.bigpond.net.au> (raw)
In-Reply-To: <3DE3EFC4.2010209@redhat.com>

On Tue, Nov 26, 2002 at 05:03:48PM -0500, Andrew Cagney wrote:
> >Was the final decision from the earlier discussion as simple as:
> 
> I don't know if anyone came up with an implementation proposal, just 
> that ``true'' and ``false'' and ``boolean'' should be removed from "bfd.h".

Heh, Andrew isn't letting this die. :)

> >typedef int bfd_boolean;
> >
> >s/boolean/bfd_boolean
> >s/true/1
> >s/false/0
> >
> >and deal with the fallout?  If so, I'm willing to do the conversion and 
> >post a patch.

This sort of patch is probably best left to a global maintainer.
It's almost as much work to review such a patch (mainly checking that
true and false in comments are unchanged) as it is to generate.

Hmm, I'm inclined to just use "int" directly rather than introduce a
"bfd_boolean".  Unless I hear objections, that's what I'll do one of
these days..

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


  reply	other threads:[~2002-11-26 22:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <555D137A-FB43-11D6-84AF-00039396EEB8@apple.com>
     [not found] ` <20021119071305.GM997@bubble.sa.bigpond.net.au>
2002-11-19  8:26   ` Andrew Cagney
2002-11-19 13:42     ` Alan Modra
2002-11-19 14:09       ` Andrew Cagney
2002-11-19 18:05         ` Klee Dienes
2002-11-20  8:05           ` Andrew Cagney
2002-11-20 15:09             ` Alan Modra
2002-11-20 22:56               ` Klee Dienes
2002-11-26 14:03                 ` Andrew Cagney
2002-11-26 14:37                   ` Alan Modra [this message]
2002-11-26 15:28                     ` Ian Lance Taylor
2002-11-26 15:57                       ` Alan Modra
2002-11-26 16:15                         ` Andrew Cagney
2002-11-27 16:44                         ` Hans-Peter Nilsson
2002-11-27 21:55                           ` Ian Lance Taylor
2002-11-28 14:39                             ` Alan Modra
2002-11-28 15:23                               ` Andrew Cagney
2002-11-28 21:04                                 ` Alan Modra
2002-11-29  0:41                                   ` Doug Evans
2002-11-29  4:02                                     ` Ben Elliston
2002-11-26 15:58                       ` Klee Dienes
2002-11-27 11:37             ` David O'Brien
2002-11-26 16:23 Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021126223746.GQ949@bubble.sa.bigpond.net.au \
    --to=amodra@bigpond.net.au \
    --cc=ac131313@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=klee@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox