From: Daniel Jacobowitz <drow@mvista.com>
To: gdb@sources.redhat.com
Subject: Re: MIPS targets broken by dummy frame/regcache changes
Date: Fri, 18 Oct 2002 17:09:00 -0000 [thread overview]
Message-ID: <20021019000932.GA10181@nevyn.them.org> (raw)
In-Reply-To: <3DB09C3E.9060706@redhat.com>
On Fri, Oct 18, 2002 at 07:41:50PM -0400, Andrew Cagney wrote:
>
> >@@ -28,9 +29,7 @@
> > int
> > mips_linux_cannot_fetch_register (int regno)
> > {
> >- if (regno >= FP_REGNUM)
> >- return 1;
> >- else if (regno == PS_REGNUM)
> >+ if (regno == PS_REGNUM)
> > return 1;
> > else if (regno == ZERO_REGNUM)
> > return 1;
> >@@ -41,9 +40,7 @@ mips_linux_cannot_fetch_register (int re
> > int
> > mips_linux_cannot_store_register (int regno)
> > {
> >- if (regno >= FP_REGNUM)
> >- return 1;
> >- else if (regno == PS_REGNUM)
> >+ if (regno == PS_REGNUM)
> > return 1;
> > else if (regno == ZERO_REGNUM)
> > return 1;
> >
> >It's wrong. First of all, you changed the behavior for registers above
> >FP_REGNUM, like UNUSED_REGNUM. Secondly, FP_REGNUM did not become OK
> >to fetch/store after this patch. Just the numbering changed.
> >
> >I'll fix it in a little bit.
>
> Ulgh, what was I thinking.
>
> The reggroup code will let this be fixed properly - can finally specify
> exactly which registers should be saved/restored across an inferior
> function call.
Looking forward to it!
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2002-10-19 0:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 13:51 Daniel Jacobowitz
2002-10-13 16:20 ` Daniel Jacobowitz
2002-10-14 10:45 ` Daniel Jacobowitz
2002-10-18 16:41 ` Andrew Cagney
2002-10-18 17:09 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021019000932.GA10181@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox