From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6050 invoked by alias); 20 Sep 2002 15:22:40 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6042 invoked from network); 20 Sep 2002 15:22:40 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 20 Sep 2002 15:22:40 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17sQY6-0000sp-00; Fri, 20 Sep 2002 11:22:34 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17sPc4-0002P9-00; Fri, 20 Sep 2002 11:22:36 -0400 Date: Fri, 20 Sep 2002 08:22:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: Alexander Larsson , gdb@sources.redhat.com, Jim Blandy Subject: Re: External debug symbols Message-ID: <20020920152236.GA9109@nevyn.them.org> Mail-Followup-To: Elena Zannoni , Alexander Larsson , gdb@sources.redhat.com, Jim Blandy References: <15755.14989.816244.777522@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15755.14989.816244.777522@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-09/txt/msg00313.txt.bz2 On Fri, Sep 20, 2002 at 11:11:09AM -0400, Elena Zannoni wrote: > > I have looked at this. I think it's a valuable thing to have. I have > a few questions about the approach, and a few more specific comments > about the code. I haven't followed all the implications of this patch. > What do other folks think? In general, I'm in love with it. > > diff --exclude '*~' --exclude '*.orig' --exclude '*.rej' --exclude '.#*' --exclude '*.o' --exclude CVS --exclude SCCS --exclude RCS --exclude '.*.flags' --exclude .cvsignore --exclude .depend -ur gdb-5.2.1/gdb/configure.in gdb-5.2.1.separate_debug_symbols/gdb/configure.in > > --- gdb-5.2.1/gdb/configure.in Thu Mar 28 05:28:00 2002 > > +++ gdb-5.2.1.separate_debug_symbols/gdb/configure.in Mon Aug 26 17:02:48 2002 > > @@ -234,6 +234,14 @@ > > AC_CHECK_LIB(socket, socketpair) > > AC_CHECK_FUNCS(socketpair) > > > > +debugdir=${libdir}/debug > > + > > +AC_ARG_WITH(separate-debug-dir, > > +[ --with-separate-debug-dir=path Look for global separate debug info in this path [LIBDIR/debug]], > > +[debugdir="${withval}"]) > > + > > +AC_DEFINE_DIR(DEBUGDIR, debugdir) > > +#AC_DEFINE_UNQUOTED(DEBUGDIR, "$debugdir"), > > > > Could this be done alternatively using an environment variable, > instead of being set at configure time? something like > DEBUG_INFO_PATH, or similar. I don't have a strong preference, but > seems to me that an environment variable is more flexible. I'd have to change this for local GDB packages anyway. Full relocatable installs are a must for me, so I'd have to make this path follow the current location of the GDB binary. I'm hoping to put the necessary support code in libiberty eventually... > Thinking out loud... > > I wonder if it wouldn't be more intuitive to add the debug info to the > objfile, instead of creating another objfile. So that in the end we > would have just a new field added to the objfile, indicating the name > of the debug info file. I like this idea; it seems a lot less fragile. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer