From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10409 invoked by alias); 16 Sep 2002 14:03:38 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 10401 invoked from network); 16 Sep 2002 14:03:37 -0000 Received: from unknown (HELO rwcrmhc52.attbi.com) (216.148.227.88) by sources.redhat.com with SMTP; 16 Sep 2002 14:03:37 -0000 Received: from ocean.lucon.org ([12.234.143.38]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020916140337.PPBD26805.rwcrmhc52.attbi.com@ocean.lucon.org>; Mon, 16 Sep 2002 14:03:37 +0000 Received: by ocean.lucon.org (Postfix, from userid 1000) id C6AB6125D8; Mon, 16 Sep 2002 07:03:35 -0700 (PDT) Date: Mon, 16 Sep 2002 07:03:00 -0000 From: "H. J. Lu" To: Earl Chew Cc: gdb@sources.redhat.com, drow@mvista.com, jimb@redhat.com Subject: Re: Mystified by "Internal error: pc 0x89f21e10 read in psymtab, but not in symtab Message-ID: <20020916070335.A1149@lucon.org> References: <3D825BB5.48CFAFAB@agilent.com> <20020913220110.GA22097@nevyn.them.org> <3D8269C8.8E33C4AC@agilent.com> <20020913225151.GA24869@nevyn.them.org> <3D8270FF.3086EA5C@agilent.com> <20020914013314.GB31038@nevyn.them.org> <3D84AAAD.6090706@agilent.com> <20020915160306.GA31994@nevyn.them.org> <20020915133938.B19112@lucon.org> <3D85614B.8010701@agilent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3D85614B.8010701@agilent.com>; from earl_chew@agilent.com on Sun, Sep 15, 2002 at 09:42:51PM -0700 X-SW-Source: 2002-09/txt/msg00201.txt.bz2 On Sun, Sep 15, 2002 at 09:42:51PM -0700, Earl Chew wrote: > H. J. Lu wrote: > > That patch is broken. See > > > > http://sources.redhat.com/ml/gdb/2002-03/msg00197.html > > http://sources.redhat.com/ml/gdb/2002-03/msg00202.html > > > > Unfortunately, no one seems to care. > > I care, I care! > > How eerie. I wrote a set of changes this morning, and now comparing > with your changes --- it's uncanny how close they are. > > I enclose my patches below for you to peruse. I have some questions > regarding some minor differences: > > a. I figured it was better in general to invoke the relocation function > pointer with the section offset structure, and let each > implementation figure out what relocations are required. I > thought that some implementations (in the future) might cache > things other than text locations (eg data locations). I don't think it helps since objfile_relocate only does offset. If you pass delta, it is no longer symmetric. You don't want to use the same function to do more than one thing here. You can always change it together when you modify objfile_relocate later. > > b. In dbxread.c, I initialise the relocate_symtab pointer in > start_psymtab _and_ end_psymtab (where the code loops and allocates > new psymtabs and copies values across). > > Your patch doesn't initialise the function pointer here, and I > believe that this will result in an uninitialised field. I might miss that one. H.J.