From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4995 invoked by alias); 26 Aug 2002 21:21:39 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 4988 invoked from network); 26 Aug 2002 21:21:38 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 26 Aug 2002 21:21:38 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17jSF7-0001My-00; Mon, 26 Aug 2002 17:21:53 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17jRJq-00058D-00; Mon, 26 Aug 2002 17:22:42 -0400 Date: Mon, 26 Aug 2002 14:21:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: Gdb List Subject: Re: build failure in TUI Message-ID: <20020826212242.GA18393@nevyn.them.org> Mail-Followup-To: Tom Tromey , Gdb List References: <87d6s5mie5.fsf@fleche.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d6s5mie5.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-08/txt/msg00338.txt.bz2 On Mon, Aug 26, 2002 at 03:15:14PM -0600, Tom Tromey wrote: > I just updated and rebuilt the gdb trunk on x86 Red Hat Linux 7.3. > > I get this: > > gcc -c -g -O2 -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/home/tromey/gnu/baseline-gdb/install/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl -DMI_OUT=1 -DTUI=1 -I../../src/gdb/tui -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Werror ../../src/gdb/tui/tuiIO.c > cc1: warnings being treated as errors > ../../src/gdb/tui/tuiIO.c: In function `tui_redisplay_readline': > ../../src/gdb/tui/tuiIO.c:190: warning: comparison is always true due to limited range of data type > ../../src/gdb/tui/tuiIO.c:193: warning: comparison is always true due to limited range of data type > > > This causes a failure because I configure with both --enable-tui and > --enable-gdb-build-warnings=,-Werror. > > I looked at the code a bit. I think the simplest fix may be to change > the definition of CTRL_CHAR (in readline/chardefs.h) to cast its > argument to `unsigned char' (and then remove the `>= 0' check). > However, I don't know the policy on changing readline, so I decided > not to send a patch. Debian has this: #define CTRL_CHAR(c) ((c) < control_character_threshold && (((c) & 0x80) == 0)) I'm not sure offhand if this is fixed in stock readline 4.3, or if it is Debian local. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer