From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-8349-listarch-gdb=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30049 invoked by alias); 9 Apr 2002 09:26:04 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 29850 invoked from network); 9 Apr 2002 09:26:00 -0000
Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2)
  by sources.redhat.com with SMTP; 9 Apr 2002 09:26:00 -0000
Received: from rembrandt.csv.ica.uni-stuttgart.de (rembrandt.csv.ica.uni-stuttgart.de [129.69.118.42])
	by iris1.csv.ica.uni-stuttgart.de (SGI-8.9.3/8.9.3) with ESMTP id LAA56825;
	Tue, 9 Apr 2002 11:25:52 +0200 (MDT)
Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian))
	id 16ursu-0002ko-00; Tue, 09 Apr 2002 11:25:52 +0200
Date: Tue, 09 Apr 2002 02:26:00 -0000
To: Andreas Schwab <schwab@suse.de>
Cc: gcc@gcc.gnu.org, binutils@sources.redhat.com, gdb@sources.redhat.com
Subject: Re: Overlapping patterns in toplevel configure.in
Message-ID: <20020409092552.GH545@rembrandt.csv.ica.uni-stuttgart.de>
References: <jeofgt5k0r.fsf@sykes.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jeofgt5k0r.fsf@sykes.suse.de>
User-Agent: Mutt/1.3.27i
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
X-SW-Source: 2002-04/txt/msg00118.txt.bz2

Andreas Schwab wrote:
> The toplevel congfigure.in script contains a case pattern *-*-linux* that
> overrules the pattern mips*-*-linux*.  The first pattern only exists in
> the gcc repository, not in the src repository.  There are also other linux
> cases that are not a superset of the generic *-*-linux* case.  What is the
> best way to resolve that?

What about doing the minimum needed to fix it? The patch below moves
it downwards and updates the mips case.

> Perhaps the generic linux pattern should be
> moved to a separate case statement.  But there is also a catch-all
> pattern at the end that disables libgcj for all not explicitly mentioned
> targets unless --enable-libgcj is given.  In other words, it's a big
> mess. :-(

The check about rx is always the same and could be moved in a seperate
statement.


Thiemo


--- configure.in	Thu Mar 28 00:32:31 2002
+++ configure.in.mipsfix	Tue Apr  9 11:14:24 2002
@@ -796,11 +796,6 @@ case "${target}" in
          target_configdirs="${target_configdirs} target-libstub target-cygmon"
     fi
     ;;
-  *-*-linux*)
-    noconfigdirs="$noconfigdirs target-newlib target-libgloss"
-    # linux has rx in libc
-    skipdirs="$skipdirs target-librx"
-    ;;
   i[3456]86-*-mingw32*)
     target_configdirs="$target_configdirs target-mingw"
     noconfigdirs="$noconfigdirs expect target-libgloss ${libgcj}"
@@ -951,7 +946,9 @@ case "${target}" in
     target_configdirs="${target_configdirs} target-bsp target-libstub target-cygmon"
    ;;
   mips*-*-linux*)
-    noconfigdirs="$noconfigdirs target-libffi"
+    noconfigdirs="$noconfigdirs target-libffi target-newlib target-libgloss"
+    # linux has rx in libc
+    skipdirs="$skipdirs target-librx"
     ;;
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof ${libgcj}"
@@ -1023,6 +1020,11 @@ case "${target}" in
     ;;
   vax-*-*)
     noconfigdirs="$noconfigdirs target-newlib target-libgloss ${libgcj}"
+    ;;
+  *-*-linux*)
+    noconfigdirs="$noconfigdirs target-newlib target-libgloss"
+    # linux has rx in libc
+    skipdirs="$skipdirs target-librx"
     ;;
   *-*-lynxos*)
     noconfigdirs="$noconfigdirs target-newlib target-libgloss ${libgcj}"