From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1652 invoked by alias); 6 Apr 2002 02:39:27 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 1645 invoked from network); 6 Apr 2002 02:39:26 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 6 Apr 2002 02:39:26 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16tg76-0007tM-00 for ; Fri, 05 Apr 2002 21:39:36 -0500 Date: Fri, 05 Apr 2002 18:39:00 -0000 From: Daniel Jacobowitz To: gdb@sources.redhat.com Subject: Re: Alpha completely broken: build_regcache never called Message-ID: <20020405213936.A22001@nevyn.them.org> Mail-Followup-To: gdb@sources.redhat.com References: <20020403180530.A570@nevyn.them.org> <3CABE158.5080706@cygnus.com> <20020404002511.A11444@nevyn.them.org> <3CAC61E0.7040300@cygnus.com> <20020404114216.A31713@nevyn.them.org> <3CAE5DCB.7080102@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CAE5DCB.7080102@cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00071.txt.bz2 On Fri, Apr 05, 2002 at 09:30:35PM -0500, Andrew Cagney wrote: > >That function only initializes things created with > >>>register_gdbarch_data... not register_gdbarch_swap. Adding a call to > >>>init_gdbarch_swap (&startup_gdbarch) in initialize_non_multiarch causes > >>>it to be called. Is that correct? > > > >> > >>Er, yes :-( Does it ``work'' (between the other two functions to match > >>gdbarch_update_p())? > > > > > >Yep. Want me to check it in? > > M'kay (thanks). No need for the branch - doesn't contain the patch that > triggered this. Sure. I committed this. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.2382 diff -u -r1.2382 ChangeLog --- ChangeLog 2002/04/06 01:52:34 1.2382 +++ ChangeLog 2002/04/06 02:37:45 @@ -1,3 +1,8 @@ +2002-04-05 Daniel Jacobowitz + + * gdbarch.sh (initialize_non_multiarch): Call init_gdbarch_swap. + * gdbarch.c: Regenerate. + 2002-04-05 Michael Snyder * cli/cli-dump.c (restore_section_callback): Use paddr_nz. Index: gdbarch.c =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.c,v retrieving revision 1.111 diff -u -r1.111 gdbarch.c --- gdbarch.c 2002/03/19 02:51:05 1.111 +++ gdbarch.c 2002/04/06 02:37:46 @@ -412,6 +412,7 @@ initialize_non_multiarch () { alloc_gdbarch_data (&startup_gdbarch); + init_gdbarch_swap (&startup_gdbarch) init_gdbarch_data (&startup_gdbarch); } Index: gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.119 diff -u -r1.119 gdbarch.sh --- gdbarch.sh 2002/03/19 02:51:07 1.119 +++ gdbarch.sh 2002/04/06 02:37:47 @@ -1333,6 +1333,7 @@ initialize_non_multiarch () { alloc_gdbarch_data (&startup_gdbarch); + init_gdbarch_swap (&startup_gdbarch) init_gdbarch_data (&startup_gdbarch); } EOF