From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14455 invoked by alias); 4 Apr 2002 05:58:23 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 14439 invoked from network); 4 Apr 2002 05:58:21 -0000 Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196) by sources.redhat.com with SMTP; 4 Apr 2002 05:58:21 -0000 Received: (from root@localhost) by neon-gw.transmeta.com (8.9.3/8.9.3) id VAA03376 for ; Wed, 3 Apr 2002 21:58:15 -0800 Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1) id xma003374; Wed, 3 Apr 02 21:58:02 -0800 Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22]) by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id g345w8N11010 for ; Wed, 3 Apr 2002 21:58:09 -0800 (PST) Received: (from dje@localhost) by casey.transmeta.com (8.9.3/8.7.3) id VAA14915; Wed, 3 Apr 2002 21:58:08 -0800 Date: Wed, 03 Apr 2002 21:58:00 -0000 Message-Id: <200204040558.VAA14915@casey.transmeta.com> X-Authentication-Warning: casey.transmeta.com: dje set sender to dje@casey.transmeta.com using -f From: Doug Evans To: gdb@sources.redhat.com Subject: bitrot in buildsym.c:start_subfile X-SW-Source: 2002-04/txt/msg00038.txt.bz2 In buildsym.c there's this: /* Start recording information about source code that came from an included (or otherwise merged-in) source file with a different name. NAME is the name of the file (cannot be NULL), DIRNAME is the directory in which it resides (or NULL if not known). */ void start_subfile (char *name, char *dirname) { `name' cannot be NULL. However, there's this: subfile->name = (name == NULL) ? NULL : savestring (name, strlen (name)); and this: if (subfile->name) Am I missing something?