From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6494 invoked by alias); 23 Feb 2002 17:23:41 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6383 invoked from network); 23 Feb 2002 17:23:37 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 23 Feb 2002 17:23:37 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 372F05E9DE; Sat, 23 Feb 2002 12:23:36 -0500 (EST) From: Jim Blandy To: Andrew Cagney Cc: gdb@sources.redhat.com Subject: Headers including other headers? Message-Id: <20020223172336.372F05E9DE@zwingli.cygnus.com> Date: Sat, 23 Feb 2002 09:23:00 -0000 X-SW-Source: 2002-02/txt/msg00273.txt.bz2 Suppose a header file in gdb/ contains code cannot be compiled without definitions from other header files --- it uses typedefs, structures in a way that requires their size, etc. Is it more proper for the header file to #include the other headers it requires itself, or should it be the responsibility of the .c file #including it to also bring in its prerequisites? In hopes that this doesn't start a really long thread of unsatisfying disagreements: I personally think that this is not a matter of huge consequence either way, but it's nicer to have a consistent pattern, so having someone simply establish any reasonable guideline is more important than the actual details of that guideline. I'm not volunteering to convert our existing headers; I just want to know what style is recommended for new header files.