Re: [RFA] remove fprintf (stderr, ...) from dwarf2read.c

Daniel Jacobowitz
2002-02-14T14:41:55Z

On Thu, Feb 14, 2002 at 01:04:18PM +0100, Pierre Muller wrote:
> Probably the obvious rule could apply here,
> but since my last "obvious fix" was a total fiasco,
> I prefer to ask once again for permission here.
>
> There are several other files that use
> fprintf (stderr,...)
>
> Here is the complete list I found:
> arm-tdep.c
> f-lang.c
> hpread.c
> i386-stub.c
> m68k-stub.c
> remote-array.c
> remote-es.c
> remote-os9k.c
> remote-st.c
> stop-gdb.c
> symm-nat.c
> gdbserver/gdbreplay.c
> gdbserver/linux-low.c
> gdbserver/low-hppabsd.c
> gdbserver/low-lynx.c
> gdbserver/low-nbsd.c
> gdbserver/low-sim.c
> gdbserver/low-sparc.c
> gdbserver/low-sun3.c
> gdbserver/remote-utils.c
> gdbserver/server.c
> gdbserver/utils.c
> nindy-share/Onindy.c
> nindy-share/nindy.c
> nlm/gdbserve.c
> rdi-share/devsw.c
> rdi-share/etherdrv.c
> rdi-share/hsys.c
>
>
> Some of these files, like i386-stub.c and m68k-stub.c don't even use defs.h
> (which contains the declaration of fprintf_unfiltered)
> and thus should not be changed but for most others (at least at gdb dir level)
> should be changed, no ?

Some of those belong to GDB and some do not. gdbserver/* do not;
i386-stub.c and m68k-stub.c do not, I believe. Most of the others do,
but it's worth verifying - nlm/gdbserve.c looks suspicious, for
example.

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer