From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28738 invoked by alias); 14 Feb 2002 14:41:55 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 28604 invoked from network); 14 Feb 2002 14:41:47 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 14 Feb 2002 14:41:47 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16bN50-0008Iq-00; Thu, 14 Feb 2002 09:41:46 -0500 Date: Thu, 14 Feb 2002 06:41:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb@sources.redhat.com Subject: Re: [RFA] remove fprintf (stderr, ...) from dwarf2read.c Message-ID: <20020214094146.A31811@nevyn.them.org> Mail-Followup-To: Pierre Muller , gdb@sources.redhat.com References: <4.2.0.58.20020214123916.019a6840@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4.2.0.58.20020214123916.019a6840@ics.u-strasbg.fr> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-02/txt/msg00214.txt.bz2 On Thu, Feb 14, 2002 at 01:04:18PM +0100, Pierre Muller wrote: > Probably the obvious rule could apply here, > but since my last "obvious fix" was a total fiasco, > I prefer to ask once again for permission here. > > There are several other files that use > fprintf (stderr,...) > > Here is the complete list I found: > arm-tdep.c > f-lang.c > hpread.c > i386-stub.c > m68k-stub.c > remote-array.c > remote-es.c > remote-os9k.c > remote-st.c > stop-gdb.c > symm-nat.c > gdbserver/gdbreplay.c > gdbserver/linux-low.c > gdbserver/low-hppabsd.c > gdbserver/low-lynx.c > gdbserver/low-nbsd.c > gdbserver/low-sim.c > gdbserver/low-sparc.c > gdbserver/low-sun3.c > gdbserver/remote-utils.c > gdbserver/server.c > gdbserver/utils.c > nindy-share/Onindy.c > nindy-share/nindy.c > nlm/gdbserve.c > rdi-share/devsw.c > rdi-share/etherdrv.c > rdi-share/hsys.c > > > Some of these files, like i386-stub.c and m68k-stub.c don't even use defs.h > (which contains the declaration of fprintf_unfiltered) > and thus should not be changed but for most others (at least at gdb dir level) > should be changed, no ? Some of those belong to GDB and some do not. gdbserver/* do not; i386-stub.c and m68k-stub.c do not, I believe. Most of the others do, but it's worth verifying - nlm/gdbserve.c looks suspicious, for example. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer