From: Richard Earnshaw <rearnsha@arm.com>
To: gdb@sources.redhat.com
Cc: Richard.Earnshaw@arm.com
Subject: Moving to GDB_MULTI_ARCH_PARTIAL
Date: Wed, 06 Feb 2002 09:21:00 -0000 [thread overview]
Message-ID: <200202061721.RAA02197@cam-mail2.cambridge.arm.com> (raw)
I'm trying to get the ARM target building now at multi-arch partial. It
seems that the auto-generated definitions at this level are to an extent
inconsistent.
For example, gdbarch_validate() requires that PUSH_ARGUMENTS is fully
implemented as a multi-arch call, but the code in gdbarch.h does not fault
a partial definition of this.
That is, in gdbarch.h we have
#if (GDB_MULTI_ARCH > GDB_MULTI_ARCH_PARTIAL) && defined (PUSH_ARGUMENTS)
#error "Non multi-arch definition of PUSH_ARGUMENTS"
#endif
#if GDB_MULTI_ARCH
#if (GDB_MULTI_ARCH > GDB_MULTI_ARCH_PARTIAL) || !defined (PUSH_ARGUMENTS)
#define PUSH_ARGUMENTS(nargs, args, sp, struct_return, struct_addr)
(gdbarch_pus
h_arguments (current_gdbarch, nargs, args, sp, struct_return, struct_addr))
#endif
#endif
but then in gdbarch_validate,
if ((GDB_MULTI_ARCH >= 1)
&& (gdbarch->push_arguments == 0))
fprintf_unfiltered (log, "\n\tpush_arguments");
Surely these two should be brought into line (one tests with ">" and the
other with ">=").
R.
next reply other threads:[~2002-02-06 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-06 9:21 Richard Earnshaw [this message]
2002-02-07 19:45 ` Andrew Cagney
2002-02-07 23:08 ` Andrew Cagney
2002-02-08 1:38 ` Richard Earnshaw
2002-02-08 7:19 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202061721.RAA02197@cam-mail2.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox