From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6265 invoked by alias); 25 Nov 2001 17:47:26 -0000 Mailing-List: contact gdb-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 6229 invoked from network); 25 Nov 2001 17:47:24 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sourceware.cygnus.com with SMTP; 25 Nov 2001 17:47:24 -0000 Received: from drow by nevyn.them.org with local (Exim 3.32 #1 (Debian)) id 1683N8-0006k1-00; Sun, 25 Nov 2001 12:47:18 -0500 Date: Tue, 13 Nov 2001 08:47:00 -0000 From: Daniel Jacobowitz To: George France Cc: gdb@sources.redhat.com, clp@iol.unh.edu Subject: Re: exit status of 'make check' Message-ID: <20011125124718.A25769@nevyn.them.org> Mail-Followup-To: George France , gdb@sources.redhat.com, clp@iol.unh.edu References: <200111212321.RAA09463@duracef.shout.net> <01112208082500.16429@shadowfax.middleearth> <20011125015054.A31912@nevyn.them.org> <01112512374200.05740@shadowfax.middleearth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01112512374200.05740@shadowfax.middleearth> User-Agent: Mutt/1.3.23i X-SW-Source: 2001-11/txt/msg00133.txt.bz2 On Sun, Nov 25, 2001 at 12:37:42PM -0500, George France wrote: > > That pretty much means that it did. You can grep for ^FAIL: to see how > > many there are. I'm hoping to see the GDB testsuite pass entirely for > > some target, someday... > > Greetings, > > Even if all the testsuites have a FAILed status, 'make check' should not > return a non-zero exit code unless there is a failure in the 'make check' > programs. The programs that comprise 'make check' should succeed. > > For example, if the "gdb.base/annota1.exp: breakpoint info" testsuite fails, > it is a failure of that testsuite, not 'make check'. Not finding 'runtest' > would be an example of a failure in 'make check', that should return a > non-zero exit code. > > Currently 'make check' always returns a non-zero exit code indicating the > testsuite results are unreliable due to a failure in 'make check'. > > I hope this makes things clearer. I really can't agree. I don't care (in an idealized world in which we've finished fixing the GDB testsuite, which we're working on...) what went wrong. I'd consider make check to have failed if a test failed - for use in, say, unattended builds. >From runtest's man page: EXIT CODES runtest sets the exit code to 1 if any of the tests failed, or sets it to 0 if all the tests passed. DejaGNU seems to agree with me on this one. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer