From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Kettenis To: gdb@sources.redhat.com, gdb-patches@sources.redhat.com Subject: [PATCH/RFC] Trim "tm-i386v.h" Date: Sun, 21 Oct 2001 07:38:00 -0000 Message-id: <200110211438.f9LEci711055@delius.kettenis.local> X-SW-Source: 2001-10/msg00216.html AFIACT we can remove a lot of junk "tm-i386v.h". The generic i386 versions in "tm-i386.h" should work fine since the System V ABI is the de facto standard ABI. The only thing that remains is START_INFERIOR_TRAPS which indeed is a System V-specific thing. If nobody speaks up in the coming week, I intend to commit the attached patch. Mark Index: ChangeLog from Mark Kettenis * config/i386/tm-i386v.h: Don't include "regcache.h". (EXTRACT_RETURN_VALUE, STORE_RETURN_VALUE, FRAME_CHAIN, FRAMELESS_FUNCTION_INVOCATION, FRAME_SAVED_PC, FRAME_NUM_ARGS): Remove macros. The versions from "tm-i386.h" should work fine (and in most cases even better). Index: config/i386/tm-i386v.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/tm-i386v.h,v retrieving revision 1.6 diff -u -p -r1.6 tm-i386v.h --- config/i386/tm-i386v.h 2001/05/08 12:00:49 1.6 +++ config/i386/tm-i386v.h 2001/10/21 14:32:47 @@ -24,7 +24,6 @@ /* First pick up the generic *86 target file. */ -#include "regcache.h" #include "i386/tm-i386.h" /* Number of traps that happen between exec'ing the shell to run an @@ -33,52 +32,5 @@ #undef START_INFERIOR_TRAPS_EXPECTED #define START_INFERIOR_TRAPS_EXPECTED 4 - -/* Extract from an array REGBUF containing the (raw) register state - a function return value of type TYPE, and copy that, in virtual format, - into VALBUF. */ - -#undef EXTRACT_RETURN_VALUE -#define EXTRACT_RETURN_VALUE(TYPE,REGBUF,VALBUF) \ - memcpy ((VALBUF), (REGBUF), TYPE_LENGTH (TYPE)) - -/* Write into appropriate registers a function return value - of type TYPE, given in virtual format. */ - -#undef STORE_RETURN_VALUE -#define STORE_RETURN_VALUE(TYPE,VALBUF) \ - write_register_bytes (0, VALBUF, TYPE_LENGTH (TYPE)) - - -/* Describe the pointer in each stack frame to the previous stack frame - (its caller). */ - -/* FRAME_CHAIN takes a frame's nominal address - and produces the frame's chain-pointer. */ - -#undef FRAME_CHAIN -#define FRAME_CHAIN(thisframe) \ - (!inside_entry_file ((thisframe)->pc) ? \ - read_memory_integer ((thisframe)->frame, 4) :\ - 0) - -/* Define other aspects of the stack frame. */ - -/* A macro that tells us whether the function invocation represented - by FI does not have a frame on the stack associated with it. If it - does not, FRAMELESS is set to 1, else 0. */ - -#undef FRAMELESS_FUNCTION_INVOCATION -#define FRAMELESS_FUNCTION_INVOCATION(FI) \ - (frameless_look_for_prologue (FI)) - -#undef FRAME_SAVED_PC -#define FRAME_SAVED_PC(FRAME) (read_memory_integer ((FRAME)->frame + 4, 4)) - -/* Return number of args passed to a frame. - Can return -1, meaning no way to tell. */ - -#undef FRAME_NUM_ARGS -#define FRAME_NUM_ARGS(fi) (-1) #endif /* ifndef TM_I386V_H */