Re: [RFC] ptid_get_pid function vs. PIDGET macro

Kevin Buettner
2001-10-10T00:01:00Z

On Oct 10, 1:27am, Andrew Cagney wrote:

> > Anyway, the reason I'd prefer to do things in this order is that
> > ptid_get_lwp() is used for fetching both LWP ids and thread ids
> > on Unixware. If we get carried away and replace all of the macros
> > with their functional equivalents, it may be a lot harder to sort
> > things out for the SCO port at some point in the future.
>
> The unixware thread code has a number of potential cleanups (some of
> which would involve core changes). Since I don't think this will happen
> soon, I think Mark's suggestion should be persued regardless.
>
> Can, instead, the unixware code be localized to unixware files? If that
> is done I can ARI the macro's so that they don't infect new code.

I think it's already fairly localized. There are some places in
generic code which call PIDGET and TIDGET, but now that I think about
it some more, it'd probably be okay to convert / deprecate these. The
files that should NOT be converted are config/i386/tm-i386v42mp.h and
uw-thread.c. So long as we avoid touching these two files (until such
time that these are properly fixed), I withdraw my objection to Mark's
proposal that we deprecate PIDGET, TIDGET, and MERGEPID in the rest of
the sources.

Mark, did you want to do this? Or should I whip up a perl script?

Kevin