Re: [rfc] Completion tests failing

Fernando Nasser
2001-09-27T08:34:00Z

Daniel Jacobowitz wrote:
>
> On Thu, Sep 27, 2001 at 08:00:40AM -0400, Fernando Nasser wrote:
> > Eli Zaretskii wrote:
> > >
> > > Given the recent changes to completion, I really don't see any sense
> > > in testing this. I'd suggest to delete the test.
> >
> > OK with me. We could also change it to accept the "t" completion
> > noted by Corinna.
> >
> > Daniel, are you sending in a patch?
>
> Actually, before I send in a patch, I have a question. I've found
> another completion bug.
>
> I wanted to get a name that I knew would complete unambiguously, so I
> tried using '"break.', which ought to complete to '"break.c"'. It
> completes instead to '"break.c ' - trailing space, no trailing quote.
>
> Am I right about what ought to happen? If so, I'll make this two
> testcases, one failing, and then try to fix it.
>

I am not 100% sure of what was Eli's intention, but I guess we would
need to add a test to add the closing quote if the filename started
with quote. (The space at the end seems normal as the completer has
found a "complete" completion (i.e., a full file name) already).

Eli is in another time zone, so we may have to wait until tomorrow
to hear from him.

Thanks for finding/fixing this.

Regards,
Fernando

--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9