From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Elena Zannoni Cc: gdb@sources.redhat.com Subject: Re: [rfc] Completion tests failing Date: Wed, 26 Sep 2001 18:42:00 -0000 Message-id: <20010926214227.A698@nevyn.them.org> References: <20010926211336.A31592@nevyn.them.org> <15282.33294.964751.338563@krustylu.cygnus.com> X-SW-Source: 2001-09/msg00218.html On Wed, Sep 26, 2001 at 09:34:06PM -0400, Elena Zannoni wrote: > Daniel Jacobowitz writes: > > I don't like failing tests... especially ones that time out after absurd > > periods of time. So, I've been looking at the testsuite, particularly > > completion.exp today. > > > > The test failing for me right now is completion for 'p "a'. The > > comments, and the testsuite, say that this is a string literal and should > > not be completed. The code tries to complete it as a location, though, and > > decides to run it through location_completer. make_symbol_completion_list > > notices the stray ", and decides not to allow completion; but > > make_source_files_completion_list does no such thing. > > > > Which behavior would people prefer? I can update the testsuite to match. > > I'd also like to add expressions like: > > > > -re "^p \"a\[^\"\]*\"$" { fail "complete 'p \"a'" } > > > > if it is not supposed to complete; that is, if gdb completes it to something > > and supplies the trailing quote, fail now, instead of waiting for timeout > > and failing the next dozen tests too. > > > > -- > > Daniel Jacobowitz Carnegie Mellon University > > MontaVista Software Debian GNU/Linux Developer > > > Daniel, is this related to the problem that Corinna was seeing? > > http://sources.redhat.com/ml/gdb-patches/2001-08/msg00299.html Thanks - I'd missed that! Yes, it's the same problem. I think that Corinna missed the comments describing the expected outcome, though - rather than papering over the problem by making '"a' ambiguous, it looks as if '"a' is not intended to complete at all. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer