From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Faylor To: gdb@sources.redhat.com Subject: Re: DOS/Windows-specific code: source.c Date: Wed, 09 May 2001 07:08:00 -0000 Message-id: <20010509100637.D31509@redhat.com> References: X-SW-Source: 2001-05/msg00186.html On Wed, May 09, 2001 at 01:07:39PM +0300, Eli Zaretskii wrote: > >On 8 May 2001, DJ Delorie wrote: > >> "Eli Zaretskii" writes: >> > Perhaps, but this is not the problem I was trying to solve. The issue >> > is whether _any_ platform needs to put O_BINARY into mode in this >> >> If it's host-specific code, perhaps. But it's better if nobody needs >> to know whether or not O_BINARY is available; they only need to know >> if it's *appropriate*. If the file is binary, use O_BINARY. If it is >> text, don't. > >This is what GDB does already. This specific case is special because >_WIN32 build wanted to read text files with O_BINARY, due to the >problems with using byte offsets to record where each line begins. > >I suggest removing that snippet, because CRLF_SOURCE_FILES already >solves the same problem in a more elegant way. The DJGPP port uses >that since at least GDB 4.18, so native Windows ports should also be >happy with it. Sounds ok to me. cgf