From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Faylor To: gdb@sources.redhat.com Subject: Re: DOS/Windows-specific code: ser-tcp.c [need ruling from Andrew] Date: Wed, 09 May 2001 06:59:00 -0000 Message-id: <20010509095816.A31509@redhat.com> References: <20010503211502.21716.qmail@web6401.mail.yahoo.com> <3AF1DAA0.3060702@cygnus.com> <200105071609.TAA24129@is.elta.co.il> <200105081154.OAA06318@is.elta.co.il> <1010509065322.ZM22268@ocotillo.lan> X-SW-Source: 2001-05/msg00183.html On Tue, May 08, 2001 at 11:53:22PM -0700, Kevin Buettner wrote: >On May 8, 2:54pm, Eli Zaretskii wrote: > >> * ser-tcp.c: >> >> #ifndef __CYGWIN32__ >> #include >> #endif >> >> Is netinet/tcp.h header specific to Cygwin? If so, this could be >> replaced by a HAVE_NETINET_TCP_H macro set by Autoconf. > >I can't comment on the Cygwin part of the question, but it seems >to me like it'd be a good idea to to use HAVE_NETINET_TCP_H. netinet/tcp.h is not specific to Cygwin. The include isn't even required on Cygwin, AFAICT. I'll submit a patch to remove it. Andrew, do I need permission to check in a Cygwin-specific change to a module that is not technically "mine" if the patch only touches Cygwin-specific code? This one is classifiable as an "obvious" fix but I'm just wondering for future reference. cgf