Re: DOS/Windows-specific code: source.c

Eli Zaretskii
2001-05-08T12:23:00Z

> Date: Tue, 8 May 2001 14:16:19 -0400
> From: Christopher Faylor <cgf@redhat.com>
>
> On Tue, May 08, 2001 at 12:22:22PM -0400, DJ Delorie wrote:
> >Eli Zaretskii <eliz@is.elta.co.il> writes:
> >> * source.c:openp()
> >>
> >> #ifdef _WIN32
> >> mode |= O_BINARY;
> >> #endif
> >>
> >>I think this is obsolete and should be removed: defining
> >>CRLF_SOURCE_FILES in xm-whatever should solve the underlying problem.
> >
> >What I do is this:
> >
> >#ifndef O_BINARY
> >#define O_BINARY 0
> >#endif
> >
> >Put that somewhere global, and then *always* use O_BINARY and don't
> >worry about it.
>
> gdb does this, too. It does it in too many (7) places, though.
> Shouldn't this be in a header file (defs.h?) somewhere?

Perhaps, but this is not the problem I was trying to solve. The issue
is whether _any_ platform needs to put O_BINARY into mode in this
case. Platforms which define O_BINARY to zero don't need to bother
about this, but Windows certainly has a non-zero O_BINARY.