Re: [Mingw-users] Re: _WIN32?

Andrew Cagney
2001-05-03T15:24:00Z

For:

> #ifndef _WIN32
> kill (PIDGET (inferior_pid), SIGINT);
> #endif
>
> would be replaced with something like this:
>
> #ifndef _N0_KILL_
> kill (PIDGET (inferior_pid), SIGINT);
> #endif

I'm actually puzzled. It looks very like someone took a shortcut and,
instead of implementing new methods, just went through and commented out
every call to kill(). cf handle_sigio().

Anyway, to answer your question:

> You are proposing that something like this in inflow.c

Yes, for the most part I would like to strongly encouraging people doing
WIN32, GO32 and CYGWIN ports to look back over all those #ifdef's and
see if they are better served by an autoconf feature test. Per my
earlier e-mail, the obvious oneis to do with how file systems are DOS
file systems are handled and there, I think things are being replaced
with a runtime test.

There is also at least one specific case, main.c, where I think the
_WIN32 test is bogus.

enjoy,
Andrew