Re: DOS/Windows-specific code: ser-tcp.c [need ruling from Andrew]

Andrew Cagney
2001-05-09T09:29:00Z

> I can't comment on the Cygwin part of the question, but it seems
>>to me like it'd be a good idea to to use HAVE_NETINET_TCP_H.
>
>
> netinet/tcp.h is not specific to Cygwin. The include isn't even required
> on Cygwin, AFAICT. I'll submit a patch to remove it.
>
> Andrew, do I need permission to check in a Cygwin-specific change to a
> module that is not technically "mine" if the patch only touches
> Cygwin-specific code?
>
> This one is classifiable as an "obvious" fix but I'm just wondering for
> future reference.

I think most host related fixes are ``obvious''. The maintainers file says:

``

Host/Native:

The Native maintainer is responsible for target specific native
support - typically shared libraries and quirks to procfs/ptrace/...
The Native maintainer works with the Arch and Core maintainers when
resolving more generic problems.

The host maintainer ensures that gdb (including mmalloc) can be built
as a cross debugger on their platform.
''

along with:

``

Makefile.in, configure* ALL
''

Getting something to build (not work) really should just involve obvious
fixes. If you find you're adding lots of #if/#elses then I suspect
alarm bells will go off in your own head - there is something wrong here
- long before you post the patch.

Besides, configury changes are mostly suck it and see - very iterative
in nature.

enjoy,
Andrew