Re: DOS/Windows-specific code: sh-tdep.c and sh3-rom.c

Eli Zaretskii
2001-05-08T11:17:00Z

> From: Elena Zannoni <ezannoni@cygnus.com>
> Date: Tue, 8 May 2001 10:49:02 -0400
>
> Eli Zaretskii writes:
> >
> > * sh-tdep.c:
> >
> > #if 0
> > #ifdef _WIN32_WCE
> > char **sh_register_names = sh3_reg_names;
> > #else
> > char **sh_register_names = sh_generic_reg_names;
> > #endif
> > #endif
> >
> > It seems we could simply remove this, since it's disabled anyway.
> >
>
> Ah, yes. Chris wrote that, and I disabled it when I multiarched the
> sh. Maybe it can be done now in a different way.

Do I understand correctly that this can be removed?

> > * sh3-rom.c:_initialize_sh3_rom()
> >
> > #ifdef _WINDOWS
> > /* On windows we can talk through the parallel port too. */
> > "Debug on a Hitachi eval board running the SH-3 rom monitor.\n"
> > "Specify the serial device it is connected to (e.g. com2).\n"
> > "If you want to use the parallel port to download to it, specify that\n"
> > "as the second argument. (e.g. lpt1)";
> > #else
> > "Debug on a Hitachi eval board running the SH-3 rom monitor.\n\
> > Specify the serial device it is connected to (e.g. /dev/ttya).";
> > #endif
> >
> > It should be good enough to have a single string here which would tell
> > that parallel port is only available on Windows.
>
> Yes, that looks like the simplest solution.

Thanks, will do.