gdb-19990209 snapshot fails to build with missing all target

rodneybrown
1999-04-01T00:00:00Z

Snapshot gdb-19990209 fails to build because of missing opcode/Makefile
all target, when configured on AIX-4.2.0, UnixWare 2.1.1 and SunOS 4.1.3.
NB - while I'm patching up rather than pulling down a full tar.gz, the brik -Cb
< gdb.crc
worked & I did (belatedly) run the postpatch scripts.

Further look at missing SOLIB_.* externals building on AIX-4.2.0
I think that the relevant defines could be copied straight from the
coff-solib.h and the include for xcoffsolib.h be pushed into a
config/ header file. The reason I haven't patched this in is that
gdb/eval.c includes xcofflib.h for a struct vmap definition.
gdb/eval.o is in gdb/Makefile COMMON_OBJS - this suggests to me that
the vmap definition needs to be separated out, since xcoffsolib.h isn't
protected for multiple inclusion, and you wouldn't want to override the
SOLIB_ definitions if you're not on AIX.
Hope this helps

bash$ lid 'SOLIB_.*'
# Editted down to missing externals on AIX
SOLIB_CREATE_CATCH_LOAD_HOOK gdb/breakpoint.c gdb/{coff-,,som}solib.h
SOLIB_CREATE_CATCH_UNLOAD_HOOK gdb/breakpoint.c gdb/{coff-,,som}solib.h
SOLIB_IN_DYNAMIC_LINKER gdb/infrun.c gdb/{coff-,,som}solib.h
SOLIB_LOADED_LIBRARY_PATHNAME gdb/breakpoint.c gdb/{coff-,,som}solib.h
SOLIB_UNLOADED_LIBRARY_PATHNAME gdb/breakpoint.c gdb/{coff-,,som}solib.h
bash$ lid coff-solib.h
coff-solib.h gdb/config/tm-lynx.h
bash$ lid somsolib.h
somsolib.h gdb/config/pa/{nm-hppab,tm-hppah}.h
bash$ lid solib.h
coff-solib.h gdb/config/tm-lynx.h
solib.h gdb/config/{nm-gnu,nm-nbsd,nm-sysv4,tm-sunos}.h
gdb/config/alpha/{nm-linux,nm-osf}.h
gdb/config/i386/{nm-fbsd,nm-i386sco5,nm-linux}.h gdb/config/m68k/nm-linux.h
gdb/config/sparc/nm-linux.h
solib_handle gdb/hppa-tdep.c gdb/testsuite/gdb.base/solib.c
som_solib_have_load_event gdb/somsolib.c gdb/somsolib.h
som_solib_have_unload_event gdb/somsolib.c gdb/somsolib.h
somsolib.h gdb/config/pa/{nm-hppab,tm-hppah}.h
xcoffsolib.h gdb/{exec,rs6000-nat,rs6000-tdep,xcoffsolib}.c
bash$ lid xcoffsolib.h
xcoffsolib.h gdb/{exec,rs6000-nat,rs6000-tdep,xcoffsolib}.c
bash$ lid vmap
vmap gdb/{exec,rs6000-nat,xcoffsolib}.c gdb/xcoffsolib.h
bfd/irix-core.c
bash$ lid vmap_and_bfd
vmap_and_bfd gdb/exec.c gdb/xcoffsolib.h
bash$ lid xcoff_relocate_symtab_hook
xcoff_relocate_symtab_hook gdb/{rs6000-nat,xcoffsolib}.c gdb/xcoffsolib.h
bash$ gid vmap
gdb/exec.c:47: struct vmap *map_vmap PARAMS ((bfd *, bfd *));
gdb/exec.c:63: static void bfdsec_to_vmap PARAMS ((bfd *, sec_ptr, PTR));
gdb/exec.c:93: struct vmap *vmap;
gdb/exec.c:101: struct vmap *vp, *nxt;
gdb/exec.c:103: for (nxt = vmap; nxt != NULL; )
gdb/exec.c:131: vmap = NULL;
gdb/exec.c:242: /* Setup initial vmap. */
gdb/exec.c:244: map_vmap (exec_bfd, 0);
gdb/exec.c:245: if (vmap == NULL)
gdb/exec.c:389: bfdsec_to_vmap(abfd, sect, arg3)
gdb/exec.c:395: struct vmap *vp;
gdb/exec.c:418: /* Make a vmap for ABFD which might be a member of the archive
ARCH.
gdb/exec.c:419: Return the new vmap. */
gdb/exec.c:421: struct vmap *
gdb/exec.c:422: map_vmap (abfd, arch)
gdb/exec.c:427: struct vmap *vp, **vpp;
gdb/exec.c:429: vp = (struct vmap *) xmalloc (sizeof (*vp));
gdb/exec.c:438: bfd_map_over_sections (abfd, bfdsec_to_vmap, &vmap_bfd);
gdb/exec.c:441: for (vpp = &vmap; *vpp; vpp = &(*vpp)->nxt)
gdb/exec.c:627: if (vmap)
gdb/exec.c:629: struct vmap *vp;
gdb/exec.c:631: printf_unfiltered ("\tMapping info for file `%s'.\n",
vmap->name);
gdb/exec.c:636: for (vp = vmap; vp; vp = vp->nxt)
gdb/rs6000-nat.c:50: #-- Multiple references
gdb/xcoffsolib.c:53: #-- Multiple references
gdb/xcoffsolib.h:20: /* The vmap struct is used to describe the virtual address
space of
gdb/xcoffsolib.h:28: struct vmap {
gdb/xcoffsolib.h:29: struct vmap *nxt; /* ptr to next in chain
*/
gdb/xcoffsolib.h:51: struct vmap *pvmap;
gdb/xcoffsolib.h:54: extern struct vmap *vmap;
bfd/irix-core.c:114: struct vmap vmap;
bfd/irix-core.c:116: val = bfd_read ((PTR)&vmap, 1, sizeof vmap, abfd);
bfd/irix-core.c:117: if (val != sizeof vmap)
bfd/irix-core.c:120: switch (vmap.v_type)
bfd/irix-core.c:139: if (vmap.v_offset == 0)
bfd/irix-core.c:144: vmap.v_len,
bfd/irix-core.c:145: vmap.v_vaddr,
bfd/irix-core.c:146: vmap.v_offset))