Re: gdb v7.0 - user defined command's document section - space prefixed end

Daniel Jacobowitz
2009-11-03T19:51:38Z

On Tue, Nov 03, 2009 at 11:43:13AM -0800, Joel Brobecker wrote:
> > I noticed my scripts didn't work under v7.0 only when I saw this bug in
> > launchpad. I guess I am not the only one who has indented "ends" this way
> > :)
> > https://bugs.launchpad.net/ubuntu/+source/gdb/+bug/461594
>
> If you could maybe help us a little bit, and track down the author
> of the patch that introduced the change of behavior, and then ask
> him whether the change was intended?

I believe it was:

2009-08-03 Jim Ingham <jingham@apple.com>
Vladimir Prus <vladimir@codesourcery.com>

Refactor reading of commands

* defs.h (read_command_lines_1): Declare.
* cli/cli-script.c (read_next_line): Only return string,
do not process.
(process_next_line): New, extracted from read_next_line.
(recurse_read_control_structure): Take a function pointer to the
read function.
(get_command_line) Pass the read_next_line as reader function
into recurse_read_control_structure.
(read_command_lines_1): New, extracted from...
(read_command_lines): ...here.

--
Daniel Jacobowitz
CodeSourcery