Re: gdb v7.0 - user defined command's document section - space prefixed end

Daniel Jacobowitz
2009-11-06T16:55:00Z

On Fri, Nov 06, 2009 at 07:40:39PM +0300, Vladimir Prus wrote:
> read_next_line already used to took process_commands parameter, and process_next_line
> was nothing but "Extract Function" refactoring, so it did not change that.
>
> The process_commands parameter was added to read_next_line for exactly the reason
> Tom suggested -- to support Python. When parsing 'python' command we need to skip
> all the way to the 'end' without stripping indentation. And when not parsing 'python'
> command, process_commands should be set. Therefore, here's the patch that should fix
> this problem. Grep claims no other problematic places.
>
> OK?

No. I don't think we should strip all whitespace and lines starting
with "#" from documentation, or do special handling of "else", or any
of the other bits enabled by parse_commands.

--
Daniel Jacobowitz
CodeSourcery