From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11182 invoked by alias); 17 Jan 2008 23:10:50 -0000 Received: (qmail 11173 invoked by uid 22791); 17 Jan 2008 23:10:49 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Jan 2008 23:10:24 +0000 Received: from kahikatea.snap.net.nz (152.60.255.123.dynamic.snap.net.nz [123.255.60.152]) by viper.snap.net.nz (Postfix) with ESMTP id C81423DA2EE; Fri, 18 Jan 2008 12:10:16 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 1833A8FC6D; Fri, 18 Jan 2008 12:10:14 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18319.57428.969644.640540@kahikatea.snap.net.nz> Date: Thu, 17 Jan 2008 23:10:00 -0000 To: Vladimir Prus Cc: gdb@sources.redhat.com Subject: RE: RE: -var-update using formatted value Newsgroups: gmane.comp.gdb.patches In-Reply-To: References: <6D19CA8D71C89C43A057926FE0D4ADAA04290E35@ecamlmw720.eamcs.ericsson.se> X-Mailer: VM 7.19 under Emacs 23.0.50.32 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00157.txt.bz2 > Update stored value when format changes. > > * varobj.c (varobj_set_display_format): Recomputed > print_value. > (c_value_of_variable): Return print_value. > > diff --git a/gdb/varobj.c b/gdb/varobj.c > index d078bef..b0eb11a 100644 > --- a/gdb/varobj.c > +++ b/gdb/varobj.c > @@ -677,6 +677,13 @@ varobj_set_display_format (struct varobj *var, > var->format = variable_default_display (var); > } > > + if (varobj_value_is_changeable_p (var) > + && var->value && !value_lazy (var->value)) > + { > + free (var->print_value); > + var->print_value = value_get_print_value (var->value, var->format); > + } > + > return var->format; > } > > @@ -2260,7 +2267,7 @@ c_value_of_variable (struct varobj *var) > > gdb_assert (varobj_value_is_changeable_p (var)); > gdb_assert (!value_lazy (var->value)); > - return value_get_print_value (var->value, var->format); > + return strdup (var->print_value); > } > } > } I don't like this change. If I change the format to hexadecimal, 11 -> 0xb say, the display should change, so I would like GDB to report it through -var-update. -- Nick http://www.inet.net.nz/~nickrob