From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22929 invoked by alias); 4 Jun 2007 02:09:28 -0000 Received: (qmail 22915 invoked by uid 22791); 4 Jun 2007 02:09:27 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 04 Jun 2007 02:09:25 +0000 Received: from kahikatea.snap.net.nz (222.61.255.123.dynamic.snap.net.nz [123.255.61.222]) by viper.snap.net.nz (Postfix) with ESMTP id 75C643D9D1C; Mon, 4 Jun 2007 14:09:22 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id EE5158F946; Mon, 4 Jun 2007 14:09:19 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18019.29775.303769.331474@kahikatea.snap.net.nz> Date: Mon, 04 Jun 2007 02:09:00 -0000 To: Daniel Jacobowitz Cc: gdb@sourceware.org Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list In-Reply-To: <20070604010633.GA927@caradoc.them.org> References: <18019.18081.448928.93993@kahikatea.snap.net.nz> <20070604010633.GA927@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.50.10 X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00026.txt.bz2 > > This change breaks the behaviour of annotations with commands that span > > multiple lines, like if, while, etc: > > Sorry, I didn't even know we had special annotations for this (and the > testsuite must not cover it). I'm not sure how to fix it, either - > the patch you cited was very tricky to come up with already :-( I've not read the thread (it looked quite long) but the problem the patch fixes (which seems to be for CLI, not TUI) doesn't seem important enough to justify such an invasive change (apologies, if it fixed further problems). For now, could you please just revert it? From my point of view, it creates a bigger problem than it fixes. Emacs 22 has just been released (but not announced). The plan is to migrate fully to MI, at which point, annotations could be removed altogether. -- Nick http://www.inet.net.nz/~nickrob