Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
		gdb@sources.redhat.com, Jim Ingham <jingham@apple.com>
Subject: Re: mi_load_progress question
Date: Thu, 13 Jul 2006 22:45:00 -0000	[thread overview]
Message-ID: <17590.52391.979539.124310@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20060713130319.GA21874@nevyn.them.org>

 > > I have no experience with remote debugging, so I can only suggest that
 > > it's consistent i.e have progress reporting for all cases or turn it off
 > > completely (I don't know how useful it is or why it should only exist in
 > > MI).
 > 
 > There's similar output from the CLI including speed and section name.

The progress reporting is described for -target-download but not mentioned
for load.

 > > If the answer is yes, I suggest something like the patch below.  Unless I'm
 > > missing something mi_load_progress only gets called in MI.  I would like to
 > > make similar but more fiddly changes to mi-interp.c, removing
 > > mi`N'_command_loop, N = 1,2,3, and just using mi_command_loop.
 > 
 > You're wrong; take a look at the URL from my message.  If you
 > type "load" at the MI prompt, the hook remains installed, but we get
 > called while the CLI is temporarily active.  Doing this will probably
 > crash.

OK.  I can see a problem now: if I start GDB normally and use a command like
"interpreter mi -environment-pwd".  Otherwise deprecated_show_load_progress is
presumably only set to mi_load_progress if GDB is invoked with "-i=mi[N]" as
there is currently there is no ability to switch interpreters permanently in
FSF GDB.  Or is the problem more general than that?

When I read the thread I thought it was referring to executing CLI commands
from MI, in which case you presumably would want the MI output.

Perhaps mi_load_progress could just do:

  if (mi_version (uiout) != 0)
    uiout = mi_out_new (mi_version (uiout));
  else
    return;

 > You can test this using gdbserver; "load" isn't useful with gdbserver,
 > but if you load the same binary gdbserver started, it works well enough
 > to test "load".

I don't see how mi_load_progress would run in this case.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


      reply	other threads:[~2006-07-13 22:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-12  8:39 Vladimir Prus
2006-07-12  9:33 ` Nick Roberts
2006-07-12 14:04   ` Daniel Jacobowitz
2006-07-12 17:34     ` Jim Ingham
2006-07-13  6:47     ` Nick Roberts
2006-07-13 13:03       ` Daniel Jacobowitz
2006-07-13 22:45         ` Nick Roberts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17590.52391.979539.124310@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=jingham@apple.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox