From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-21979-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 31999 invoked by alias); 27 Jun 2005 14:07:33 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 31674 invoked by uid 22791); 27 Jun 2005 14:07:27 -0000
Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 27 Jun 2005 14:07:27 +0000
Received: from farnswood.snap.net.nz (p214-tnt1.snap.net.nz [202.124.110.214])
	by viper.snap.net.nz (Postfix) with ESMTP id 141EE552231;
	Tue, 28 Jun 2005 02:07:24 +1200 (NZST)
Received: by farnswood.snap.net.nz (Postfix, from userid 501)
	id D4F5562A99; Mon, 27 Jun 2005 15:08:23 +0100 (BST)
From: Nick Roberts <nickrob@snap.net.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17088.2134.821855.942376@farnswood.snap.net.nz>
Date: Mon, 27 Jun 2005 14:07:00 -0000
To: Bob Rossi <bob@brasko.net>
Cc: Daniel Jacobowitz <drow@false.org>,
	Mark Kettenis <kettenis@gnu.org>, gdb@sourceware.org
Subject: Re: MI-related testsuite regressions
In-Reply-To: <20050627135610.GA19376@white>
References: <200506270815.j5R8FZO6026261@jop31.nfra.nl>
	<17087.60064.541364.938844@farnswood.snap.net.nz>
	<20050627130030.GA10394@nevyn.them.org>
	<17088.1264.104928.522819@farnswood.snap.net.nz>
	<20050627135610.GA19376@white>
X-SW-Source: 2005-06/txt/msg00262.txt.bz2

 > > -i=mi sets mi_version to 2 in my copy:
 > > 
 > >   interp_add (interp_new (INTERP_MI, NULL, mi_out_new (2), &procs));
 > > 
 > > and
 > > 
 > >   if (current_interp_named_p (INTERP_MI1))
 > >     deprecated_command_loop_hook = mi1_command_loop;
 > >   else if (current_interp_named_p (INTERP_MI2))
 > >     deprecated_command_loop_hook = mi2_command_loop;
 > >   else if (current_interp_named_p (INTERP_MI3))
 > >     deprecated_command_loop_hook = mi3_command_loop;
 > >   else
 > >     deprecated_command_loop_hook = mi2_command_loop;
 > > 
 > > 
 > > As far as I can see mi3 does nothing that mi2 doesn't do.
 > 
 > I think the ideology is that mi3 is allowed to change in such a way that
 > mi2 is not. So, all new features go into mi3, while mi2 should remain
 > stable and unchanged, except for bug fixes and minor new improvements
 > that are backwards compatible.

If thats the case, shouldn't the code read:

   interp_add (interp_new (INTERP_MI, NULL, mi_out_new (3), &procs));
 
 and
 
   if (current_interp_named_p (INTERP_MI1))
     deprecated_command_loop_hook = mi1_command_loop;
   else if (current_interp_named_p (INTERP_MI2))
     deprecated_command_loop_hook = mi2_command_loop;
   else if (current_interp_named_p (INTERP_MI3))
     deprecated_command_loop_hook = mi3_command_loop;
   else
     deprecated_command_loop_hook = mi3_command_loop;


as it stands the mi-*.exp don't test mi3.


Nick