From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27350 invoked by alias); 20 Feb 2004 17:33:12 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 27342 invoked from network); 20 Feb 2004 17:33:11 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 20 Feb 2004 17:33:11 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 2EA3E1A448A; Fri, 20 Feb 2004 12:28:44 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16438.17356.108792.625555@localhost.redhat.com> Date: Fri, 20 Feb 2004 17:33:00 -0000 To: Daniel Jacobowitz Cc: Elena Zannoni , David Carlton , gdb@sources.redhat.com Subject: Re: Huge slowdown since 6.0 In-Reply-To: <20040220164704.GA11587@nevyn.them.org> References: <20040218210927.GA16641@nevyn.them.org> <20040220050905.GA15209@nevyn.them.org> <16438.14300.323849.306261@localhost.redhat.com> <20040220164704.GA11587@nevyn.them.org> X-SW-Source: 2004-02/txt/msg00284.txt.bz2 Daniel Jacobowitz writes: > On Fri, Feb 20, 2004 at 11:37:48AM -0500, Elena Zannoni wrote: > > Daniel Jacobowitz writes: > > > How can they possibly be to blame? Well, they are. And reverting the > > > change for enumerators definitely won't do any harm. Take a look at > > > this, read it two or three times if necessary - it took me about a > > > dozen: > > > > > > > > - &objfile->static_psymbols, > > > > > + cu_language == language_cplus > > > > > + ? &objfile->static_psymbols > > > > > + : &objfile->global_psymbols, > > > > > > If I swap "static" and "global", it reduces GDB startup time by roughly > > > 40% for glibc with debug information, which contains a lot of C > > > enumerators. I assume that is what you meant to do in the first place? > > > If so I can recover the speed hit for C for GDB 6.1, and then address > > > the larger issues with large numbers of global psymbols in HEAD after > > > we branch. > > > > Another point in favor of the theory that conditional expressions are > > bad. > > > > This should be fine, consider it preapproved. However, what you are > > really saying is that qsort performance is really bad in case we have > > lots of symbols to sort. But how many symbols? You didn't post the > > numbers. > > OK, I'll post it to gdb-patches and check it in, later today. > > What numbers would you like besides these? I can generate anything else > you're interested in. > http://sources.redhat.com/ml/gdb/2004-02/msg00236.html > > The list padding makes those numbers inexact, but the gist is: about > 3200 global symbols with enumerators static, and about 700,000 with > them global. yeah, these ones. Wow.