From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10271 invoked by alias); 2 Oct 2002 23:11:01 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 10264 invoked from network); 2 Oct 2002 23:11:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Oct 2002 23:11:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g92Mq5i22456 for ; Wed, 2 Oct 2002 18:52:05 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g92NAxf18945 for ; Wed, 2 Oct 2002 19:10:59 -0400 Received: from localhost.redhat.com (IDENT:root@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g92NAx906335 for ; Wed, 2 Oct 2002 19:10:59 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 244CDFF79; Wed, 2 Oct 2002 19:08:36 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15771.31859.903292.158527@localhost.redhat.com> Date: Wed, 02 Oct 2002 16:11:00 -0000 To: jingham@apple.com Cc: gdb@sources.redhat.com Subject: event-loop.c changes X-SW-Source: 2002-10/txt/msg00025.txt.bz2 Jim, I am looking at some of the changes in event-loop.c (from Keith's branch). I am not sure about a couple of things: This comment: void gdb_setup_readline (void) { /* This function is a noop for the async case. The assumption is that the async setup is ALL done in gdb_init, and we would only mess it up here. The async stuff should really go away over time. */ if (event_loop_p) { [...] } } You meant 'sync' instead of 'async'? The creation of these: gdb_stdout = stdio_fileopen (stdout); gdb_stderr = stdio_fileopen (stderr); gdb_stdlog = gdb_stderr; /* for moment */ gdb_stdtarg = gdb_stderr; /* for moment */ Is done in main.c, then again here, in gdb-setup-readline(). But a comment in gdb_disable_readline suggests that they really shouldn't be created here at all. /* FIXME - It is too heavyweight to delete and remake these every time you run an interpreter that needs readline. It is probably better to have the interpreters cache these, which in turn means that this needs to be moved into interpreter specific code. */ Thanks Elena