From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-8291-listarch-gdb=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 1094 invoked by alias); 4 Apr 2002 18:08:32 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 1087 invoked from network); 4 Apr 2002 18:08:31 -0000
Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196)
  by sources.redhat.com with SMTP; 4 Apr 2002 18:08:31 -0000
Received: (from root@localhost)
	by neon-gw.transmeta.com (8.9.3/8.9.3) id KAA04133;
	Thu, 4 Apr 2002 10:08:29 -0800
Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1)
	id xma004107; Thu, 4 Apr 02 10:08:02 -0800
Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22])
	by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id g34I84N04720;
	Thu, 4 Apr 2002 10:08:04 -0800 (PST)
Received: (from dje@localhost) by casey.transmeta.com (8.9.3/8.7.3) id KAA13548; Thu, 4 Apr 2002 10:08:04 -0800
From: Doug Evans <dje@transmeta.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15532.38532.462684.678414@casey.transmeta.com>
Date: Thu, 04 Apr 2002 10:08:00 -0000
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb@sources.redhat.com
Subject: Re: bitrot in buildsym.c:start_subfile
In-Reply-To: <3CAC5A6B.8090803@cygnus.com>
References: <200204040558.VAA14915@casey.transmeta.com>
	<3CAC5A6B.8090803@cygnus.com>
X-SW-Source: 2002-04/txt/msg00060.txt.bz2

Andrew Cagney writes:
 > > In buildsym.c there's this:
 > > 
 > > /* Start recording information about source code that came from an
 > >    included (or otherwise merged-in) source file with a different
 > >    name.  NAME is the name of the file (cannot be NULL), DIRNAME is
 > >    the directory in which it resides (or NULL if not known).  */
 >
 > Guess the comment is wrong.  Any hints from the 
 > callers?

If name is NULL when subfiles is not-NULL, start_subfile will segv
in FILENAME_CMP [maybe subfiles will always be NULL when name is NULL].

What does it mean for name to be NULL?