From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19064 invoked by alias); 20 Nov 2001 16:44:30 -0000 Mailing-List: contact gdb-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 19032 invoked from network); 20 Nov 2001 16:44:26 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sourceware.cygnus.com with SMTP; 20 Nov 2001 16:44:26 -0000 Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA20696 for ; Tue, 20 Nov 2001 08:44:22 -0800 (PST) Received: (from ezannoni@localhost) by rtl.cygnus.com (8.11.2/8.11.0) id fAKGoms01293; Tue, 20 Nov 2001 11:50:48 -0500 X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15354.35304.932930.264859@krustylu.cygnus.com> Date: Thu, 08 Nov 2001 19:15:00 -0000 To: gdb@sources.redhat.com Subject: What's the correct type for {supply,fill}_fpregset? X-Mailer: VM 6.97 under Emacs 20.7.1 X-SW-Source: 2001-11/txt/msg00096.txt.bz2 In compiling natively on a ppc linux system, using -Werror, I get this: gcc -c -g -O2 -I. -I/home/ezannoni/uberbaum/src/gdb -I/home/ezannoni/uberbaum/src/gdb/config -DHAVE_CONFIG_H -I/home/ezannoni/uberbaum/src/gdb/../include/opcode -I/home/ezannoni/uberbaum/src/gdb/../readline/.. -I../bfd -I/home/ezannoni/uberbaum/src/gdb/../bfd -I/home/ezannoni/uberbaum/src/gdb/../include -I../intl -I/home/ezannoni/uberbaum/src/gdb/../intl -DMI_OUT=1 -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized -Werror /home/ezannoni/uberbaum/src/gdb/thread-db.c cc1: warnings being treated as errors /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers': /home/ezannoni/uberbaum/src/gdb/thread-db.c:802: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers': /home/ezannoni/uberbaum/src/gdb/thread-db.c:835: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type /home/ezannoni/uberbaum/src/gdb/thread-db.c:841: warning: passing arg 2 of pointer to function from incompatible pointer type What is the correct/preferred solution here? Is the type of {supply,fill}_fpregset's argument wrong? It matches what in gregset.h, but few other *-linux-nat.c declare those functions the same way ppc-linux-nat.c does. The defintions in use are from ppc-linux-nat.c: void fill_fpregset (gdb_fpregset_t *fpregsetp, int regno) void supply_fpregset (gdb_fpregset_t * fpregsetp) Or should the calls in thread-db.c be changed? If this is too hard to get right for all systems, I'll submit a patch to Makefile.in that disables -Werror for thread-db.c. Thanks Elena