From: "Tiago Stürmer Daitx" <tdaitx@linux.vnet.ibm.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: GDB Development <gdb@sourceware.org>
Subject: Re: Get longjmp target check in breakpoint.c - is it necessary?
Date: Thu, 31 Oct 2013 14:46:00 -0000 [thread overview]
Message-ID: <1383230800.5925.110.camel@localhost.localdomain> (raw)
In-Reply-To: <52725AB4.5080002@linux.vnet.ibm.com>
On Thu, 2013-10-31 at 11:27 -0200, Edjunior Barbosa Machado wrote:
> What if you try to move this 'if' to a bit below in the function (right
> before "for (i = 0; i < NUM_LONGJMP_NAMES; i++)" loop)?
Good catch, I didn't notice the 'if' is kind of an optimization for the
scenarios where <arch>_get_longjmp_target is not provided. Moving it
down before that 'for NUM_LONGJMP_NAMES' loop would work nicely as
probes would work.
The no changes were detected in the testsuite by moving the 'if' before
the 'for' compared to removing it altogether.
Regards,
Tiago
--
Tiago Stürmer Daitx
tdaitx@linux.vnet.ibm.com
IBM - Linux Technology Center
next prev parent reply other threads:[~2013-10-31 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 2:36 Tiago Stürmer Daitx
2013-10-31 13:27 ` Edjunior Barbosa Machado
2013-10-31 14:46 ` Tiago Stürmer Daitx [this message]
2013-10-31 14:46 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383230800.5925.110.camel@localhost.localdomain \
--to=tdaitx@linux.vnet.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox