From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25240 invoked by alias); 1 Sep 2009 20:10:40 -0000 Received: (qmail 25225 invoked by uid 22791); 1 Sep 2009 20:10:39 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_55,RCVD_IN_DNSWL_LOW,RCVD_IN_JMF_BL,SPF_PASS X-Spam-Check-By: sourceware.org Received: from eir.is.scarlet.be (HELO eir.is.scarlet.be) (193.74.71.27) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Sep 2009 20:10:33 +0000 Received: from [172.17.1.10] (ip-81-11-243-185.dsl.scarlet.be [81.11.243.185]) by eir.is.scarlet.be (8.14.2/8.14.2) with ESMTP id n81KA8XV009519; Tue, 1 Sep 2009 22:10:08 +0200 Subject: Re: Build question From: Danny Backx Reply-To: danny.backx@scarlet.be To: Eli Zaretskii Cc: tromey@redhat.com, gdb@sourceware.org In-Reply-To: <83zl9e8nro.fsf@gnu.org> References: <1250803105.11282.96.camel@pavilion> <83d46pgjkq.fsf@gnu.org> <1250877901.11282.116.camel@pavilion> <83ab1tgh9h.fsf@gnu.org> <1250880746.11282.128.camel@pavilion> <1250931899.11282.142.camel@pavilion> <83skfkfa4n.fsf@gnu.org> <1251095160.16357.352.camel@pavilion> <1251828295.6106.119.camel@pavilion> <83zl9e8nro.fsf@gnu.org> Content-Type: text/plain Date: Tue, 01 Sep 2009 20:10:00 -0000 Message-Id: <1251835928.6106.124.camel@pavilion> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-DCC-scarlet.be-Metrics: eir 20001; Body=4 Fuz1=4 Fuz2=4 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00008.txt.bz2 On Tue, 2009-09-01 at 22:31 +0300, Eli Zaretskii wrote: > > From: Danny Backx > > Cc: tromey@redhat.com, gdb@sourceware.org > > Date: Tue, 01 Sep 2009 20:04:55 +0200 > > > > Getting most things I care about to work is done by simplifying > > include/filenames.h so it unconditionally takes the DOS versions of > > IS_DIR_SEPARATOR() and IS_ABSOLUTE_PATH(). > > If Unix users will not be too unhappy about that, as Daniel says, I > don't mind. But I still think it's a better idea to have a > user-settable option to control that at runtime. I'm not opposed to introducing user-settable options, I just phrased the analysis based on what I saw. > > The code in bfd/archive.c could probably be cleaned up based on > > IS_DIR_SEPARATOR. > Even better, just use lbasename or even basename. Except (see also your other mail) this is in libiberty. > > Same, I think, for gdb/cli/cli-cmds.c. > > No, this one needs another macro: FILENAME_PREFIX_LEN, which should be > 1 on Posix platforms and 3 on DOS-ish systems. Use the DOS-ish > variant on Posix systems if "d:/foo" is not an important file name. Should I then look into : - changing HAVE_DOS_BASED_FILE_SYSTEM into a variable - doing the same thing for FILENAME_PREFIX_LEN and FILENAME_CMPN Danny -- Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info