Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Danny Backx <danny.backx@scarlet.be>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb@sourceware.org
Subject: Re: Build question
Date: Fri, 21 Aug 2009 20:15:00 -0000	[thread overview]
Message-ID: <1250880746.11282.128.camel@pavilion> (raw)
In-Reply-To: <83ab1tgh9h.fsf@gnu.org>

On Fri, 2009-08-21 at 21:21 +0300, Eli Zaretskii wrote: 
> > > The way these macros and the corresponding source fragments in GDB are
> > > set, they only DTRT for native debugging.
> > 
> > Also right, but it looks like it doesn't take much to make it just work.
> 
> I think they need to be converted to run-time tests instead.  For
> that, we would probably need some kind of primitive that returns the
> filesystem type of the target, what the macros do now at compile-time.

That doesn't look right.

I am building i386-mingw32ce-gdb (or arm-mingw32ce-gdb). The targets
specified are Windows CE based, so they all have this "DOS BASED" file
system. So why test this at run time ?

The total extent of the patches I needed to get this particular issue
out of the way is this :
pavilion: {868} cvs diff include/filenames.h
Index: include/filenames.h
===================================================================
RCS file: /cvs/src/src/include/filenames.h,v
retrieving revision 1.5
diff -u -r1.5 filenames.h
--- include/filenames.h 21 Mar 2008 23:40:18 -0000      1.5
+++ include/filenames.h 21 Aug 2009 18:41:44 -0000
@@ -36,6 +36,10 @@
 #define HAVE_DOS_BASED_FILE_SYSTEM 1
 #endif
 
+#endif
+
+#ifdef HAVE_DOS_BASED_FILE_SYSTEM
+
 #define IS_DIR_SEPARATOR(c)    ((c) == '/' || (c) == '\\')
 /* Note that IS_ABSOLUTE_PATH accepts d:foo as well, although it is
    only semi-absolute.  This is because the users of IS_ABSOLUTE_PATH

And in the build directory, I added
 #define HAVE_DOS_BASED_FILE_SYSTEM 1
to libiberty/config.h and gdb/config.h .

I am looking for a way to get this into the build system somehow.

	Danny
-- 
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


  reply	other threads:[~2009-08-21 18:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  0:24 Danny Backx
2009-08-21 17:30 ` Tom Tromey
2009-08-21 17:57   ` Eli Zaretskii
2009-08-21 18:23     ` Danny Backx
2009-08-21 18:51       ` Eli Zaretskii
2009-08-21 20:15         ` Danny Backx [this message]
2009-08-21 21:57           ` Eli Zaretskii
2009-08-22  9:03           ` Tom Tromey
2009-08-22  9:55             ` Danny Backx
2009-08-22 11:07               ` Eli Zaretskii
2009-08-24 10:11                 ` Danny Backx
2009-09-01 18:03                   ` Danny Backx
2009-09-01 19:34                     ` Eli Zaretskii
2009-09-01 20:10                       ` Danny Backx
2009-09-02  3:25                         ` Eli Zaretskii
2009-09-05  9:33                           ` Danny Backx
2009-09-01 19:35                     ` Eli Zaretskii
2009-08-22 22:01             ` Daniel Jacobowitz
2009-08-23  7:28               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250880746.11282.128.camel@pavilion \
    --to=danny.backx@scarlet.be \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox