From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8867 invoked by alias); 19 Jul 2008 05:53:03 -0000 Received: (qmail 8850 invoked by uid 22791); 19 Jul 2008 05:53:02 -0000 X-Spam-Check-By: sourceware.org Received: from hel.is.scarlet.be (HELO hel.is.scarlet.be) (193.74.71.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 19 Jul 2008 05:52:33 +0000 Received: from [172.17.1.2] (ip-62-235-161-158.dsl.scarlet.be [62.235.161.158] (may be forged)) by hel.is.scarlet.be (8.14.2/8.14.2) with ESMTP id m6J5qRAm023570; Sat, 19 Jul 2008 07:52:28 +0200 Subject: Re: Your bfd changes broke sh sim From: Danny Backx Reply-To: danny.backx@scarlet.be To: Hans-Peter Nilsson Cc: dannybackx@users.sourceforge.net, binutils@sourceware.org, gdb@sourceware.org In-Reply-To: <200807190352.m6J3qdr0011498@ignucius.se.axis.com> References: <200807190352.m6J3qdr0011498@ignucius.se.axis.com> Content-Type: text/plain Date: Sat, 19 Jul 2008 06:45:00 -0000 Message-Id: <1216446747.30145.46.camel@dannypc> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0-1mdv2007.0 Content-Transfer-Encoding: 7bit X-DCC--Metrics: hel 0; Body=5 Fuz1=5 Fuz2=5 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00221.txt.bz2 On Sat, 2008-07-19 at 05:52 +0200, Hans-Peter Nilsson wrote: > > From: Danny Backx > > Date: Fri, 18 Jul 2008 20:12:39 +0200 > > > I've tested (and tested again) with > > ./configure --enable-targets=all > > Looks like you didn't even try and build binutils *without* > --enable-targets=all, because you broke e.g. sh-elf (and yes, > sh-pe too). For --target=sh-elf, make all: I was told to check --enable-targets=all in addition to what I was doing (several arm targets). I did that. Here's what I just found (unless I overlooked something) : - I argued with Nick about where this code needed to be, the initial place was peXXigen.c but I argued that this appeared to be the wrong place because it could get generated more than once. - Then I was given a choice where to put it, evidently I made the wrong choice (pe-arm-wince.c). - I just moved it back and tested with three builds : configure --enable-targets=all configure --target=arm-wince configure --target=sh-elf and found that only the last one failed to build, even with the code in peXXigen.c. - Inspection reveals that peXXigen.c isn't compiled for sh-elf, so this was the wrong choice too. I see three options : - remove the line that causes this in coff-sh.c and change it as in all the other architectures. Then all this only works for ARM, not for ARM and SH as it is supposed to. - remove all the smart configuration stuff that Nick talked me into and revert all this to a dumb ARM-only patch - find a better place to store the code Please advise. Danny > I suggest you revert your change and move > pe_print_ce_compressed_pdata out of pe-arm-wince.c (clearly the > wrong place) and into peXXigen.c or its own file (don't forget > to adjust the build machinery), making it the default of a > target-dependent hook, overridden for pe-mips or something. > > brgds, H-P > -- Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info