From: Kevin Buettner <kevinb@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>, gdb@sources.redhat.com
Subject: Re: target_terminal_ours and target_terminal_ours_for_output
Date: Wed, 29 Oct 2003 05:20:00 -0000 [thread overview]
Message-ID: <1031029051957.ZM4933@localhost.localdomain> (raw)
In-Reply-To: Elena Zannoni <ezannoni@redhat.com> "target_terminal_ours and target_terminal_ours_for_output" (Oct 28, 12:35pm)
On Oct 28, 12:35pm, Elena Zannoni wrote:
> I was looking at Jeff's patch, and noticed that we have two target
> methods, called to_target_terminal_ours and
> to_target_terminal_ours_for_output. We then have two functions
> target_terminal_ours and target_terminal_ours_for_output (in inflow.c)
> which behave exaclty the same (look at the parameter of
> terminal_ours_1 not being used at all).
>
> I cannot find any target that sets these pair of methods differently,
> i.e. there is no difference between the two, ever.
>
> Should one of the two be deleted? At some point the two functions in
> inflow.c used to differ, but in 1993 the difference was deleted,
> i.e. the parameter of terminal_ours_1 stopped being used.
> Seems this is something that should be cleaned up.
I agree.
Kevin
prev parent reply other threads:[~2003-10-29 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-28 17:35 Elena Zannoni
2003-10-29 5:20 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031029051957.ZM4933@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ezannoni@redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox