Re: register_offset_hack() vs REGISTER_BYTE()

[Kevin Buettner <kevinb@redhat.com>]

On May 2,  6:26pm, Andrew Cagney wrote:

> > Can probably change REGISTER_BYTE to a pre-initialized method with
> > predicate (see DEPRECATED_PC_IN_CALL_DUMMY for an example), and
> > then add a predicate test for it to the above mix.
> 
> On second thoughts, and having investigate things a bit further ... 
> Doing it would revert any architecture [still] defining REGISTER_BYTE 
> (almost all of them) back to using the legacy register cache. 
> Consequently I'll instead just add sanity checks to ensure that the 
> regcache and REGISTER_BYTE are consistent.
> 
> > Sentinel frame should probably also be switched to using
> > register_offset_hack(), instead of REGISTER_BYTE(), so that it is
> > more consistent with the frame code.
> 
> Appears to work.
> 
> > Sounds like it's time to s/ REGISTER_BYTE /
> > DEPRECATED_REGISTER_BYTE /.  It isn't yet possible to eliminate
> > that macro from the MIPS since it is that hardwired mystery that
> > defines the MIPS remote protocol :-(
> 
> ...

For MIPS register numbers in [0, NUM_REGS), I'm going to make
mips_register_virtual_type() always return a type whose size is the same as
that currently returned by mips_register_raw_size().  I'll introduce pseudo
registers for those that actually need different virtual sizes.  (I've
turned mips o32 floating point registers into pseudo registers already and
it seems to work...)

This'll allow me to eliminate the MIPS REGISTER_BYTE and REGISTER_RAW_SIZE
definitions.  Plus some other stuff too.  E.g, I've already gotten rid of
mips_register_convert_to_type() and mips_register_convert_from_type().  I
think mips_register_convert_to_virtual() and mips_register_convert_to_raw()
will end up going away too.

Kevin