From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27503 invoked by alias); 27 Jan 2003 17:11:13 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 27491 invoked from network); 27 Jan 2003 17:11:13 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 27 Jan 2003 17:11:13 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0RGg0f12871 for ; Mon, 27 Jan 2003 11:42:00 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0RHBCa09024; Mon, 27 Jan 2003 12:11:12 -0500 Received: from localhost.localdomain (vpn50-39.rdu.redhat.com [172.16.50.39]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0RHBCt24184; Mon, 27 Jan 2003 12:11:12 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h0RHB6W20143; Mon, 27 Jan 2003 10:11:06 -0700 Date: Mon, 27 Jan 2003 17:11:00 -0000 From: Kevin Buettner Message-Id: <1030127171106.ZM20142@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "gdb_indent vs. dwarf2read" (Jan 26, 10:11pm) References: <20030127031101.GA17969@nevyn.them.org> To: Daniel Jacobowitz , gdb@sources.redhat.com Subject: Re: gdb_indent vs. dwarf2read MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-01/txt/msg00432.txt.bz2 On Jan 26, 10:11pm, Daniel Jacobowitz wrote: > What do people think about adding "-T bfd -T asection" to gdb_indent.sh? I think it makes sense. > [I'd like to re-indent dwarf2read.c, so I was looking over the results of > gdb_indent.sh on it before posting the patch. Other churn: structs moved > from two spaces indented to the left column, which matches the general style > in GDB; and comments like: > 1) foo > bar > reindented to > 1) foo > bar > . Should we slavishly obey GNU indent in this, or should I reformat the > comments by hand before posting the reindentation patch?] The problem with reformatting the comments (or anything else) by hand is that someone else who runs GNU indent probably won't do the same hand formatting. If there's something you don't want indent to touch, use /* *INDENT-OFF* */ (and later on, at the right point, /* *INDENT-ON* */. Kevin