From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>, gdb@sources.redhat.com
Subject: Re: [rfc] ``pc'' -> resume_addr?
Date: Thu, 11 Apr 2002 13:58:00 -0000 [thread overview]
Message-ID: <1020411205831.ZM3555@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@cygnus.com> "[rfc] ``pc'' -> resume_addr?" (Apr 11, 4:38pm)
On Apr 11, 4:38pm, Andrew Cagney wrote:
> GDB, in a number of places, refers to the ``pc'' - PC_REGNUM, frame->pc,
> read_pc(), write_pc(), ...
>
> I think this name choice was unfortunate. It is too easy for a
> developer to confuse ``pc'' with the hardware ``pc''.
Could you please explain further why you think the name choice was
unfortunate?
> With this in mind, I'd like to propose a GDBspeak ``resume_addr''. It
> is the address of the first instruction that will be executed when the
> target resumes.
So, if I understand you correctly, you're suggesting the following
renaming:
PC_REGNUM ==> RESUME_ADDR_REGNUM
frame->pc ==> frame->resume_addr
read_pc() ==> read_resume_addr()
write_pc() ==> write_resume_addr()
Perhaps I've just gotten fond of ``pc'', but I don't really like any
of these.
Kevin
next prev parent reply other threads:[~2002-04-11 20:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-11 13:38 Andrew Cagney
2002-04-11 13:58 ` Kevin Buettner [this message]
2002-04-11 15:15 ` Andrew Cagney
2002-04-11 16:35 ` Andrew Cagney
2002-04-11 16:48 ` Kevin Buettner
2002-04-11 17:08 ` Andrew Cagney
2002-04-11 17:37 ` Michael Snyder
2002-04-11 16:42 ` Kevin Buettner
2002-04-11 17:39 ` Michael Snyder
2002-04-11 17:34 ` Michael Snyder
2002-04-12 8:59 ` Andrew Cagney
2002-04-13 20:21 ` Andrew Cagney
2002-04-11 17:25 ` Michael Snyder
2002-04-26 8:09 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020411205831.ZM3555@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@cygnus.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox