From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6387 invoked by alias); 19 Sep 2006 18:31:39 -0000 Received: (qmail 6379 invoked by uid 22791); 19 Sep 2006 18:31:38 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 19 Sep 2006 18:31:37 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id A313626A81; Tue, 19 Sep 2006 11:31:35 -0700 (PDT) Received: from mx2.palmsource.com ([127.0.0.1]) by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31209-01-23; Tue, 19 Sep 2006 11:31:34 -0700 (PDT) Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) by mx2.palmsource.com (Postfix) with ESMTP id 77B2B269C9; Tue, 19 Sep 2006 11:31:34 -0700 (PDT) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: gdb (ARM processor) casting issues in iwmmxt.c Date: Tue, 19 Sep 2006 18:31:00 -0000 Message-ID: <0F4DF2E21F33DD46BE7B8CDEEB0E16D307EACB@ussunex01.palmsource.com> References: <8c7950360609190443n3e48263cg5a3638da76d6dc3b@mail.gmail.com> From: "Michael Snyder" To: , X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00108.txt.bz2 Are you on a branch? The casts that you want to change don't seem to be in my version of the source file (which according to CVS, is up to date). Michael -----Original Message----- From: gdb-owner@sourceware.org on behalf of shanevolpe@gmail.com Sent: Tue 9/19/2006 4:43 AM To: gdb@sourceware.org Subject: gdb (ARM processor) casting issues in iwmmxt.c =20 All, I tried compiling gdb client for the xscale processor and all works good but for some casting issues in iwmmxt.c Here is what I found: There is casting occurring on the target: (unsigned long) s1 =3D a * b; I changed all the castings to only cast on the source and not target.. After my modifications everything compiled fine. Below is a patch file with my changes. I'm not sure if there is something I'm missing, I have never seen casting on the target before. Patch: --- gdb-6.3/sim/arm/iwmmxt~old.c 2003-03-27 12:13:33.000000000 -0500 +++ gdb-6.3/sim/arm/iwmmxt.c 2006-09-18 15:26:05.000000000 -0400 @@ -2114,7 +2114,7 @@ s =3D (signed long) a * (signed long) b; - (signed long long) t +=3D s; + t +=3D (signed long long)s; } else { @@ -2130,7 +2130,7 @@ wR [BITS (12, 15)] =3D 0; if (BIT (21)) /* Signed. */ - (signed long long) wR[BITS (12, 15)] +=3D (signed long long) t; + wR[BITS (12, 15)] +=3D (signed long long) t; else wR [BITS (12, 15)] +=3D t; @@ -2166,7 +2166,7 @@ b =3D wRHALF (BITS (0, 3), i * 2); b =3D EXTEND16 (b); - (signed long) s1 =3D a * b; + s1 =3D (signed long)a * (signed long)b; a =3D wRHALF (BITS (16, 19), i * 2 + 1); a =3D EXTEND16 (a); @@ -2174,7 +2174,7 @@ b =3D wRHALF (BITS (0, 3), i * 2 + 1); b =3D EXTEND16 (b); - (signed long) s2 =3D a * b; + s2 =3D (signed long)a * (signed long)b; } else /* Unsigned. */ { @@ -2183,12 +2183,12 @@ a =3D wRHALF (BITS (16, 19), i * 2); b =3D wRHALF (BITS ( 0, 3), i * 2); - (unsigned long) s1 =3D a * b; + s1 =3D (unsigned long)a *(unsigned long) b; a =3D wRHALF (BITS (16, 19), i * 2 + 1); b =3D wRHALF (BITS ( 0, 3), i * 2 + 1); - (signed long) s2 =3D a * b; + s2 =3D (signed long)a * (signed long)b; } r |=3D (ARMdword) ((s1 + s2) & 0xffffffff) << (i ? 32 : 0); --=20 Registered Linux User: #293401